902084 - firefox 24.0b1 l10n repacks for macosx64 fail

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P1)

Description

[Massimo Gervasini [:massimo]]

macosx64 l10n repacks for firefox 24.0b1 failed with the following error:

In file included from /builds/slave/rel-m-beta-osx64_rpk_2-0000000/mozilla-beta/mfbt/tests/TestAtomics.cpp:6:
../../dist/include/mozilla/Atomics.h:443:34: error: cannot initialize a parameter of type 'volatile int *' with an rvalue of type 'long *'
      return __sync_fetch_and_or(&ptr, val);
                                 ^~~~
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[3]: *** [TestAtomics.o] Error 1
make[2]: *** [libs] Error 2
make[1]: *** [libs_tier_base] Error 2
make: *** [tier_base] Error 2

Full log here:
http://buildbot-master65.srv.releng.usw2.mozilla.com:8001/builders/release-mozilla-beta-macosx64_repack_2%2F10/builds/2/steps/run_script/logs/stdio

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Use tooltool manifest to grab packages

This + the buildbotcustom gets us clang 3.2 installed in staging runs.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Use the tooltool clang

Opt en-US builds include
 http://hg.mozilla.org/releases/mozilla-beta/file/default/browser/config/mozconfigs/macosx-universal/common-opt
but that includes
 http://hg.mozilla.org/releases/mozilla-beta/file/default/build/macosx/universal/mozconfig.common
which has a lot of extra stuff in it. This is the next level down (build/macosx/mozconfig.common), which is just clang and ccache. 

With the other two patches I get through configure and the various makes to pulling locale source (which doesn't work because I didn't set that up).

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] pass tooltool_manifest_src to create_repack.sh

... if the platform has it set (mac/linux32/linux64).

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 786662 [details] [diff] [review]
[buildbotcustom] pass tooltool_manifest_src to create_repack.sh

I guess this will affect linux32,64 as well?

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 786660 [details] [diff] [review]
[tools] Use tooltool manifest to grab packages

Looks like we're hardcoding the runtime-binaries url here, but it's the same for staging/prod, and hopefully we move to mh l10n sooner than later.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 786662 [details] [diff] [review]
[buildbotcustom] pass tooltool_manifest_src to create_repack.sh

http://hg.mozilla.org/build/buildbotcustom/rev/8916b754a93c

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 786660 [details] [diff] [review]
[tools] Use tooltool manifest to grab packages

https://hg.mozilla.org/build/tools/rev/e41c04a4836e

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 786661 [details] [diff] [review]
[buildbot-configs] Use the tooltool clang

https://hg.mozilla.org/build/buildbot-configs/rev/6a59394c14ec

Should be good to go once we merge these patches to production and retag.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Merged to production and tags moved.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Looking good after the first locale completed. All 10 repack jobs are running.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Builds were all green.