[SkiaGL] Free Layer resource when CanvasContext got demoted

RESOLVED FIXED in mozilla26

Status

()

Core
Canvas: 2D
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pchang, Assigned: pchang)

Tracking

unspecified
mozilla26
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
With skiaGL Canvas enabled, playing "cut the rope" didn't switch to next level during level switch. Need to switch twice to make screen updated.

http://people.mozilla.com/~pchang/ctr/
(Assignee)

Updated

5 years ago
Assignee: nobody → pchang
(Assignee)

Comment 1

5 years ago
Created attachment 786440 [details] [diff] [review]
bug-902103-fix

For "Cut the rope", it was easy that CanvasContext got demoted during level switching. With skiaGL canvas, the GLContext/GLScreenBuffer will be referred by CanvasLayer. Therefore, we also need to set mResetLayer as true when we clear mTarget.
Attachment #786440 - Flags: review?(snorp)
(Assignee)

Updated

5 years ago
Blocks: 858237
Comment on attachment 786440 [details] [diff] [review]
bug-902103-fix

Yup looks good to me, but we need a gfx peer to review. George the rescue!
Attachment #786440 - Flags: review?(snorp)
Attachment #786440 - Flags: review?(gwright)
Attachment #786440 - Flags: review+
Attachment #786440 - Flags: review?(gwright) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 786918 [details] [diff] [review]
free layer when context demote happened

add reviewer in patch
Attachment #786440 - Attachment is obsolete: true
Attachment #786918 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/941a79e0c3ad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.