Closed
Bug 902103
Opened 12 years ago
Closed 12 years ago
[SkiaGL] Free Layer resource when CanvasContext got demoted
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: pchang, Assigned: pchang)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.10 KB,
patch
|
pchang
:
review+
|
Details | Diff | Splinter Review |
With skiaGL Canvas enabled, playing "cut the rope" didn't switch to next level during level switch. Need to switch twice to make screen updated.
http://people.mozilla.com/~pchang/ctr/
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → pchang
|
|
Assignee | |
Comment 1•12 years ago
|
||
For "Cut the rope", it was easy that CanvasContext got demoted during level switching. With skiaGL canvas, the GLContext/GLScreenBuffer will be referred by CanvasLayer. Therefore, we also need to set mResetLayer as true when we clear mTarget.
Attachment #786440 -
Flags: review?(snorp)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 786440 [details] [diff] [review]
bug-902103-fix
Yup looks good to me, but we need a gfx peer to review. George the rescue!
Attachment #786440 -
Flags: review?(snorp)
Attachment #786440 -
Flags: review?(gwright)
Attachment #786440 -
Flags: review+
|
||
Updated•12 years ago
|
Attachment #786440 -
Flags: review?(gwright) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
add reviewer in patch
Attachment #786440 -
Attachment is obsolete: true
Attachment #786918 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 4•12 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•