Remove the trackhandle Layer names

RESOLVED WONTFIX

Status

Webmaker
Popcorn Maker
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: igoryen, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Instead of "Layer 0", "Layer 1", "Layer 3" etc., it would be enough to just display the numbers alone.
(Reporter)

Updated

4 years ago
Assignee: nobody → igor.yentaltsev
(Reporter)

Comment 1

4 years ago
Created attachment 786476 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/154
Attachment #786476 - Flags: review?(scott)
Comment on attachment 786476 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/154

Yeah, as Matt said, removing that variable requires all uses of it to be removed.

Which also means you likely need to remove https://github.com/igoryen/popcorn.webmaker.org/blob/b8bc3efedb0badfb0cc1486f1da1a6e2f6373532/public/src/core/track.js#L21

This is going to cascade into removing a bunch of things, which is fine.

Example: https://github.com/igoryen/popcorn.webmaker.org/blob/b8bc3efedb0badfb0cc1486f1da1a6e2f6373532/public/src/core/track.js#L77

That's a getter and setter that other files could be using which also needs to be removed.

Example: https://github.com/igoryen/popcorn.webmaker.org/blob/b8bc3efedb0badfb0cc1486f1da1a6e2f6373532/public/src/timeline/trackhandles.js#L95

That track.name is interfacing with the getting and setter.

You also have to consider removing the cases where we display track.name.

Two of the areas you're concerned with regarding display are https://github.com/igoryen/popcorn.webmaker.org/blob/b8bc3efedb0badfb0cc1486f1da1a6e2f6373532/public/src/timeline/trackhandles.js#L95 and this one: https://github.com/igoryen/popcorn.webmaker.org/blob/b8bc3efedb0badfb0cc1486f1da1a6e2f6373532/public/src/timeline/trackhandles.js#L192
Attachment #786476 - Flags: review?(scott) → review-
(Reporter)

Comment 3

4 years ago
Comment on attachment 786476 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/154

Layer names are believed to be unnecessary and good to be removed.
(Reporter)

Updated

4 years ago
Summary: Remove the "Layer" NAME_PREFIX as unneded → Remove the trackhandle Layer names
(Reporter)

Updated

4 years ago
Assignee: igor.yentaltsev → nobody
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

4 years ago
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.