902123 - The background of the landing page is darker once e.me has been opened

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

With e.me on the landing page once you have opened it the background of the landing page is darker.

There are UI/UX discussions about if it should always be darker or not...

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: darker.patch

This is a very small CSS fix from evyater that should make 1.1. The risk are really low.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/3075fba41a472194bf04a3507d6341e31d416b3f

Comment 3

[Alex Keybl [:akeybl]]

This is being tested alongside bug 838634, so in the unlikely case that this causes a regression, we'll back out.

Comment 4

[Montoya Clemmons (MClemmons)]

Downloaded build from 08062013 and witnessed reported behavior. 

Downloaded latest build and witnessed resolved/fixed behavior. 

Background is not as dark as previously reported. 

Build ID: 20130813041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/36bbc5943448
Gaia: df57dcec720493bedff4601499d78c147ad7d253
Platform Version: 18.1
RIL Version: 01.01.00.019.190 
Firmware version: D300f08o

Comment 5

[Alex Keybl [:akeybl]]

Meant to leo+ in comment 3.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  3075fba41a472194bf04a3507d6341e31d416b3f
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

This bug was partially uplifted.

Uplifted 3075fba41a472194bf04a3507d6341e31d416b3f to:
v1.2 already had this commit

Commit 3075fba41a472194bf04a3507d6341e31d416b3f didn't uplift to branch v1-train

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

This bug was partially uplifted.

Uplifted 3075fba41a472194bf04a3507d6341e31d416b3f to:
v1.3 already had this commit

Commit 3075fba41a472194bf04a3507d6341e31d416b3f didn't uplift to branch v1-train