Closed Bug 902157 Opened 6 years ago Closed 6 years ago

ASAN: Add another memory-saving option for test slaves with 2-4 GB memory

Categories

(Release Engineering :: General, defect, critical)

x86_64
Linux
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [asan][asan-test-failure][asan-test-blocker])

Attachments

(1 file)

In bug 833018, we previously added a special ASAN_OPTIONS value when running on test machines that have only 2 GB or memory or less because otherwise, the tests would OOM.

I found out now that some test machines have 3.75 GB RAM (and therefore run in normal memory configuration), but they still OOM in mochitest-bc. I added a second step in the code (a "mid-memory configuration" for 2 GB < mem < 4 GB) and that turned the tests all green \o/

It also makes the memory-configuration decision a bit more verbose for the log.
Assignee: nobody → choller
Status: NEW → ASSIGNED
Attachment #786493 - Flags: review?(jmaher)
Found in triage.
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: catlee
Summary: ASan: Add another memory-saving option for test slaves with 2-4 GB memory → ASAN: Add another memory-saving option for test slaves with 2-4 GB memory
Comment on attachment 786493 [details] [diff] [review]
asan-mid-memory-saving.patch

Review of attachment 786493 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the good comments.
Attachment #786493 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/a3e34b989ebe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.