Closed
Bug 902157
Opened 11 years ago
Closed 11 years ago
ASAN: Add another memory-saving option for test slaves with 2-4 GB memory
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: decoder, Assigned: decoder)
References
(Blocks 1 open bug)
Details
(Keywords: sec-want, Whiteboard: [asan][asan-test-failure][asan-test-blocker])
Attachments
(1 file)
|
1.74 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
In bug 833018, we previously added a special ASAN_OPTIONS value when running on test machines that have only 2 GB or memory or less because otherwise, the tests would OOM. I found out now that some test machines have 3.75 GB RAM (and therefore run in normal memory configuration), but they still OOM in mochitest-bc. I added a second step in the code (a "mid-memory configuration" for 2 GB < mem < 4 GB) and that turned the tests all green \o/ It also makes the memory-configuration decision a bit more verbose for the log.
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Found in triage.
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: catlee
Summary: ASan: Add another memory-saving option for test slaves with 2-4 GB memory → ASAN: Add another memory-saving option for test slaves with 2-4 GB memory
|
||
Comment 3•11 years ago
|
||
Comment on attachment 786493 [details] [diff] [review] asan-mid-memory-saving.patch Review of attachment 786493 [details] [diff] [review]: ----------------------------------------------------------------- thanks for the good comments.
Attachment #786493 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Onward to glory! https://hg.mozilla.org/integration/mozilla-inbound/rev/a3e34b989ebe
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a3e34b989ebe
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
|
|
||
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•