902170 - Suppress 'PAC file installed' message when running tests

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

There currently is a *huge* message printed by ProxyAutoConfig at the start of every test run. This gets really annoying when trying to debug and run tests on your machine. Can we maybe only show this message in debug mode? Or maybe not at all?

Here is what this message looks like: http://pastebin.mozilla.org/2797063

Comment 1

[Patrick McManus [:mcmanus]]

ha! - data: URIs as PAC URIs - what a hack.

Anyhow - can you confirm the builds here satisfy your needs?
https://tbpl.mozilla.org/?tree=Try&rev=3acaae2b1f48

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

\o/ This works great, thank you.

Comment 3

[Patrick McManus [:mcmanus]]

Attachment: don't log data: PAC URIs to JS console

Comment 4

[Jason Duell]

Comment on attachment 789539 [details] [diff] [review]
don't log data: PAC URIs to JS console

Review of attachment 789539 [details] [diff] [review]:
-----------------------------------------------------------------

A thing of beauty is a joy forever :)

::: netwerk/base/src/ProxyAutoConfig.cpp
@@ +601,5 @@
>    JSAutoRequest ar(mJSRuntime->Context());
>    JSAutoCompartment ac(mJSRuntime->Context(), mJSRuntime->Global());
>  
> +  // this is not on the main thread, so it can't use nsIRUI scheme methods
> +  bool isDataURI = nsDependentCSubstring(mPACURI, 0, 5).LowerCaseEqualsASCII("data:", 5);

maybe add comment?

  // we don't want to print data:: URIs to the console as they can be long.

Comment 5

[Patrick McManus [:mcmanus]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/26373e95498d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26373e95498d