902199 - Travis build errors after E.me landing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

Lint errors:

make lint

=========

# --disable 210,217,220,225 replaces --nojsdoc because it's broken in closure-linter 2.3.10

# http://code.google.com/p/closure-linter/issues/detail?id=64

gjslint --disable 210,217,220,225 -r apps -r shared -e 'homescreen/everything.me,pdfjs/content,pdfjs/test,email/build,email/built,email/js/ext,calendar/js/ext,tools/,b2g/' -x 'build/r.js,apps/communications/contacts/oauth2/js/parameters.js,apps/calendar/js/presets.js,apps/email/js/alameda.js,apps/email/js/tmpl_builder.js,shared/js/opensearch.js'

Skipping 58 file(s).

----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/homescreen/js/configurator.js -----

Line 32, E:0002: Missing space before "?"

----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/homescreen/js/homescreen.js -----

Line 167, E:0131: Single-quoted string preferred over double-quoted string.

Found 2 errors, including 0 new errors, in 2 files (909 files OK).



Some of the errors reported by GJsLint may be auto-fixable using the script

fixjsstyle. Please double check any changes it makes and report any bugs. The


Test errors:

Keyboard layout changed to newLanguage

✖ 1 of 4191 tests failed:

1) [homescreen] "after each" hook:

Error: TypeError: callback is not a function (http://homescreen.gaiamobile.org:8080/shared/js/opensearch.js?time=1375826726484:178)

at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959)

make: *** [test-agent-test] Error 1

Lint error. Scroll up to see the output.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github Pull Request

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 786544 [details]
Github Pull Request

Shame on me again.

Comment 3

[Kevin Grandon :kgrandon]

I fixed these specific issues in master: https://github.com/mozilla-b2g/gaia/commit/90c0082813ba82cfcc46e9d79bb6114034c8dd31

It appears that there's additional failing tests though, will open up a follow-up bug.