Closed
Bug 902210
Opened 11 years ago
Closed 11 years ago
Suppress the indirect call static analysis hazard in GetWeakmapKeyDelegate
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.23 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
This indirect call cannot trigger GC, so we should just suppress it. I think the attached should work.
Attachment #786573 -
Flags: review?(sphink)
|
Assignee | |
Comment 1•11 years ago
|
||
Forgot to qref before uploading.
Attachment #786573 -
Attachment is obsolete: true
Attachment #786573 -
Flags: review?(sphink)
Attachment #786588 -
Flags: review?(sphink)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 786588 [details] [diff] [review]
hazard_getWeakmapKeyDelegate-v1.diff
Review of attachment 786588 [details] [diff] [review]:
-----------------------------------------------------------------
Doh! Sorry, this one is totally my fault. I removed this line from ignoreFunctions in an unrelated change:
"JSObject* js::GetWeakmapKeyDelegate(JSObject*)" : true, // FIXME: mark with AutoAssertNoGC instead
because I somehow managed to convince myself that it was no longer necessary.
I think yours is probably better than my original. And the right-er long term fix would probably be to declare tracing to be a GC-free zone, rather than sticking an in-code annotation in this particular place. Is there some easy way to do that, do you think?
Attachment #786588 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Maybe we could just put a SuppressGC in Collect?
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•