Closed
Bug 902231
Opened 11 years ago
Closed 11 years ago
Fix the exact rooting hazard in Environment in XPCShellEnvironment
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
3.54 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This is in the testshell, so I think we should just re-root this global reference.
Attachment #786603 -
Flags: review?(jcoppeard)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 786603 [details] [diff] [review]
hazard_Environment-v0.diff
Review of attachment 786603 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Attachment #786603 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
||
Comment 3•11 years ago
|
||
Not sure how I missed it, but there was a stray change in the patch to the rooting analysis. Fortunately you seem to have spotted this before pushing.
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•