902233 - Failing unit tests after E.me landing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

Linter issues have been resolved, but failing tests remain. Here is one failure, I did manage to fix this one, but ran into others:

 ✖ 1 of 4187 tests failed:

1) [homescreen] everything.me.js > "before all" hook:

TypeError: activationIcon is null

at EverythingME_init (http://homescreen.gaiamobile.org:8080/everything.me/js/everything.me.js:15)

at (anonymous) (http://homescreen.gaiamobile.org:8080/test/unit/everything.me_test.js:17)

at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)

at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)

at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)

at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)

at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)



Normally we would back out the offending patch, but due to the urgency I'm not sure if that is a good idea here. I'll leave it up to you guys to see if we can promptly fix the failing tests.

Comment 1

[Anthony Ricaud (:rik)]

Needinfo-ing people.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Not seeing an obvious reason for this Travis test fail.
Vivien, what are we missing?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The test fails because it uses a fake DOM to check the behavior of E.me. Sounds weird to me but we will fix it. It affects only master fwiw.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/dd5cbea47bf33fa05cba65262ee613db0d681c20