902304 - consider allowing the creation of array buffers with a length of 0x80000000.

Status: RESOLVED DUPLICATE of bug 1392234

(Core :: JavaScript Engine, defect)

Description

[Douglas Crosher [:dougc]]

Asm.js constrains the heap size to be a power of two, and combined with the constraint that the largest array length is 0x7fffffff this limits asm.js code to a maximum heap size of 1GB.  It is quite likely that the asm.js compiler already generates code that could handle a 2GB heap size, and this should be practical on the x64

Comment 1

[Luke Wagner [:luke]]

This seems fine; ArrayBufferObject::byteLength() and ElementsHeader::initializedLength already use uint32_t.  It seems mostly just a matter of searching for the uses of INT32_MAX vm/TypedArrayObject.cpp (e.g. createBufferWithSizeAndCount).  Do you see any problems Steve?

Comment 2

[Luke Wagner [:luke]]

Also, this would be a VM-wide change, not specific to Odin.

Comment 3

[Steve Fink [:sfink] [:s:]]

I'm going to clear this 3 year old needinfo, as I don't really having anything useful to say. This has come up again recently, though I wasn't involved -- or rather, a request for a 2^53 limit recently came up.