902362 - DOMRequestHelper specifies _requests as array, but should be object

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

In base/dom/DOMRequestHelper.jsm, this._requests is defined as an array. However the variable is never used as an array because non-numeric keys are set and thus it's an object in disguise. I think we should change it to an object.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Fabrice, can you ni? this to someone who could verify this?

Comment 2

[[:fabrice] Fabrice Desré]

Yes, it looks like we should change that. Do you mind writing the patch?

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: 902362.diff

I have done a `grep _requests -R .` in mozilla-central and so far I can only see the mozKeyboard using DOMRequestHelper.prototype._requests directly. And that already handles it correctly. So I think it's safe.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 787379 [details] [diff] [review]
902362.diff

Review of attachment 787379 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on this patch.

The code using _requests directly in mozKeyboard.js should be changed though.

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch including commit message

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

Checkin needed for 'Patch including commit message'

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/0003022755b9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0003022755b9