Closed Bug 902427 Opened 11 years ago Closed 11 years ago

Reader Mode toolbar buttons are not visible after installing "Mobile Image Blocker" add-on

Categories

(Firefox for Android Graveyard :: General, defect)

25 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox23 affected, firefox24 affected, firefox25 affected, firefox26 affected)

RESOLVED INVALID
Tracking Status
firefox23 --- affected
firefox24 --- affected
firefox25 --- affected
firefox26 --- affected

People

(Reporter: u421692, Assigned: mhaigh)

Details

Attachments

(1 file)

Environment:
Device: LG Nexus 4 (Android 4.2.2)
Build: Nightly 26.0a1 (2013-08-06)

Steps to reproduce:
1. Install "Mobile Image Blocker" add-on.
2. Open an article in reader mode.
3. Tap on screen to see the reader mode toolbar.

Expected result:
Reader mode toolbar is displayed correctly.

Actual result:
Reader Mode toolbar buttons are present and active but are not visible.(see attached screenshot)
Summary: Reader Mode toolbar buttons are not visible after "Mobile Image Blocker" add-on → Reader Mode toolbar buttons are not visible after installing "Mobile Image Blocker" add-on
Component: Add-on Manager → General
Tracking? We should fix add-ons not breaking functionality of the browser.
tracking-fennec: --- → ?
This is a bug in the addon, but since it's written by a mozillian we should be able to get it fixed. The add-on contains a content-policy that rejects any content image load of any kind. I believe the purpose of the add-on is to save on data charges and not to create featureless web pages, so resource: and chrome: images should always be fine.

The "right" way to do this would be to use the IOService to get the protocol handler for each URI scheme and ask for the protocol flags--you can find examples of this by using mxr to look for getProtocolHandler in .js file (for perf reasons might want to cache references to the common protocol handlers). Then allow protocols with the flag URI_IS_LOCAL_RESOURCE,  or if you want to block data: and only allow chrome: and resource: then look for URI_IS_UI_RESOURCE.

The "cheap" way to do it is to just check the scheme and whitelist a few that you allow through (data: resource: chrome: at least).
Assignee: nobody → mhaigh
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
tracking-fennec: ? → ---
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: