Closed
Bug 902485
Opened 12 years ago
Closed 12 years ago
Disallow copy-construction and operator= on WebIDL union structs
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
It's a footgun, as bug 772765 comment 62 shows.
![]() |
Assignee | |
Comment 1•12 years ago
|
||
In fact, I think we should do this for UnionMember<T>. That ought to be good enough.
Assignee: nobody → bzbarsky
![]() |
Assignee | |
Comment 2•12 years ago
|
||
Attachment #786965 -
Flags: review?(dzbarsky)
![]() |
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
Updated•12 years ago
|
Attachment #786965 -
Flags: review?(dzbarsky) → review+
Comment 3•12 years ago
|
||
Push backed out for Windows build failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=26277854&tree=Mozilla-Inbound
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/11e2c4170bed
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4b50c8c081fc
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/84010c0ebe0c
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5d8cf15c3b
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/eae52d24d046
![]() |
Assignee | |
Comment 4•12 years ago
|
||
Looks like Windows doesn't like the assignment operator on a union member.
![]() |
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/842a0836dcd3 with just the operator and ctor on the generated structs.
Flags: in-testsuite?
Whiteboard: [need review]
Target Milestone: --- → mozilla26
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•