902485 - Disallow copy-construction and operator= on WebIDL union structs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's a footgun, as bug 772765 comment 62 shows.

Comment 1

[Boris Zbarsky [:bzbarsky]]

In fact, I think we should do this for UnionMember<T>.  That ought to be good enough.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Disallow copy constructors and operator= on WebIDL union structs, because those wouldn't do what you think they should.

Comment 3

[Ed Morley [:emorley]]

Push backed out for Windows build failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=26277854&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/11e2c4170bed
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4b50c8c081fc
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/84010c0ebe0c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5d8cf15c3b
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/eae52d24d046

Comment 4

[Boris Zbarsky [:bzbarsky]]

Looks like Windows doesn't like the assignment operator on a union member.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/842a0836dcd3 with just the operator and ctor on the generated structs.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/842a0836dcd3