902562 - Add tests for keyboard/IME api

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Yuan Xulei [:yxl] (Leave from May 18)]

We need a way to test the keyboard API and ensure it is correctly implemented.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Expose new API to desktop helper & some first tests

This enables us to use mozInputMethod from FF Desktop when developing Gaia or running unit tests.

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 787459 [details] [review]
Expose new API to desktop helper & some first tests

I would like to add it as regular unit test but I couldn't make the keyboard API sideload in a test, therefore it's a standalone mocha app that runs as an application on the device (or as an application in FF desktop).

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Comment on attachment 787459 [details] [review]
Expose new API to desktop helper & some first tests

Reassigning because it's mainly tests around the B2G code...

Comment 4

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 787459 [details] [review]
Expose new API to desktop helper & some first tests

Hi Jan, I add some comments to the pull request(https://github.com/mozilla-b2g/gaia/pull/11426). The patch is almost done and just need a few fixes.

Comment 5

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 787459 [details] [review]
Expose new API to desktop helper & some first tests

I'm not familar Gaia Unit test, so I ask Rudy to review the gaia part.

Comment 6

[Yuan Xulei [:yxl] (Leave from May 18)]

Hi Jan, I think mochitest on gecko would be the best choice of testing the keyboard API. But it seems there is some problem running mochiest on b2g-desktop and device now. When the probem is fixed, we hope these tests will be moved to mochitest.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 787459 [details] [review]
Expose new API to desktop helper & some first tests

Hi, if the test itself is focusing on Gecko changes, I would suggest it tested by mochi-test or something that used for Gecko tests instead of using Gaia unit test framework.

From Gaia point of view, what we need first is a "keyboard API testbed".
 1. the testbed itself is a keyboard (IME) app.
 2. It has the simplest UI to invoke each function of keyboard API.
    like, one button for sendKey(), and another for getting inputContext, etc.

Jan,
Does this make sense to you?

Thank you for your effort.

Comment 8

[Jan Jongboom [:janjongboom] (inactive)]

As per bug 899999 :fabrice wanted to land these tests in Gaia. Can you live with that?

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Ok, then I'll take a look.
Thanks.

Comment 10

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 787459 [details] [review]
Expose new API to desktop helper & some first tests

I've run the tests with Firefox Nightly and it could work.
r=me.


Jan,

Thanks for this great work.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Since Bug 899073 has landed, the test should be modified, especially for getText() part.

Comment 12

[Jan Jongboom [:janjongboom] (inactive)]

I've landed the patch because of bug 906497 but will write a new patch for the changes to WebIDL. https://github.com/mozilla-b2g/gaia/commit/ef43d4242989cac29ef464508cb9c55d7954ae54

Comment 14

[Jan Jongboom [:janjongboom] (inactive)]

Let's continue in bug 906096 and close this one.

Comment 15

[Yuan Xulei [:yxl] (Leave from May 18)]

Hi Jan, it seems this bug has nothing to do with bug 906096(Ensure keyboard continues to work in Firefox Nightly).
The api tests should be working on at least b2g desktop and device. It is optional to work on Firefox desktop nightly build.

Did you close the wrong bug?

Comment 16

[Jan Jongboom [:janjongboom] (inactive)]

No, but I needed to touch Gaia in bug 906096 anyway, so porting over the WebIDL to browser-helper and fixing the tests in Gaia could be in one go. It makes no sense to have them in two different PRs.