902609 - xpcshell manifests should parse in strict mode

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Gregory Szorc [:gps]]

I hooked up the manifest parser to moz.build files and strict mode was throwing some errors! We should make all manifests parse in strict mode.

Patch forthcoming. Try at https://tbpl.mozilla.org/?tree=Try&rev=04bfb48f6186

Comment 1

[Gregory Szorc [:gps]]

Attachment: Make xpcshell.ini manifests strict mode compliant

So far I've found one bad syntax and one file that was defined but
doesn't exist! Will wait on Try for review so we only do this once.

Comment 2

[Joshua Cranmer [:jcranmer]]

xpcshell-unpack does exist, but it is generated by some build step as a copy of xpcshell.

Comment 3

[Gregory Szorc [:gps]]

Yup. And looking at the libs:: rule in the Makefile makes me sob. Ugh.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/814808c7bba8

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/814808c7bba8