Closed
Bug 902609
Opened 8 years ago
Closed 8 years ago
xpcshell manifests should parse in strict mode
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
Details | Diff | Splinter Review |
I hooked up the manifest parser to moz.build files and strict mode was throwing some errors! We should make all manifests parse in strict mode. Patch forthcoming. Try at https://tbpl.mozilla.org/?tree=Try&rev=04bfb48f6186
Assignee | ||
Comment 1•8 years ago
|
||
So far I've found one bad syntax and one file that was defined but doesn't exist! Will wait on Try for review so we only do this once.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gps
Comment 2•8 years ago
|
||
xpcshell-unpack does exist, but it is generated by some build step as a copy of xpcshell.
Assignee | ||
Comment 3•8 years ago
|
||
Yup. And looking at the libs:: rule in the Makefile makes me sob. Ugh.
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/814808c7bba8
Flags: in-testsuite-
Comment 5•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/814808c7bba8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•