test_bug475156.html failing on b2g mochitest with (NS_NOINTERFACE) [nsISupports.QueryInterface]

RESOLVED FIXED in mozilla26

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

Tracking

Trunk
mozilla26
x86
macOS
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment, 2 obsolete attachments)

Follow-up from bug 901343, comment 7.
This is the code that's causing this error:
20   var ch = SpecialPowers.wrap(xhr).channel.QueryInterface(SpecialPowers.Ci.nsICachingChannel);

from bug 901343, comment 8:
"
Well, necko in a child process acts a bit differently... e.g. HttpChannelChild does not in fact QI to nsICachingChannel.  So at least that test will need fixing to work in an e10s environment...
"
Posted patch 475156.diff (poc) (obsolete) — Splinter Review
This is a poc patch that seems to work, not sure if this is the best way to fix this.
Attachment #787112 - Flags: feedback?(bzbarsky)
Comment on attachment 787112 [details] [diff] [review]
475156.diff (poc)

Honza?
Attachment #787112 - Flags: feedback?(bzbarsky) → feedback?(honzab.moz)
Assignee: nobody → martijn.martijn
Fromm bug 901343, comment 10:
Yes, we deliberately split out a subset of the the nsICachingChannel features into nsICacheInfoChannel, which is all that you get on the child side at the moment.
Posted patch 475156.diff (obsolete) — Splinter Review
Ok, QI to nsICacheInfoChannel works very well, also works on desktop, so I can just replace the existing nsICachingChannel, I think.
Attachment #787112 - Attachment is obsolete: true
Attachment #787112 - Flags: feedback?(honzab.moz)
Attachment #787371 - Flags: review?(jduell.mcbugs)
Comment on attachment 787371 [details] [diff] [review]
475156.diff

Review of attachment 787371 [details] [diff] [review]:
-----------------------------------------------------------------

glad that worked.
Attachment #787371 - Flags: review?(jduell.mcbugs) → review+
Just to make sure it's not causing failures somehow on some platform, I pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=16f49767dff7
Everything green, this is for check-in.
Attachment #787371 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2f8ad5343149
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.