902735 - [Buri][TOR][Contacts]The contacts were disappeared,when you import many contacts from Gmail

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.179
 Firefox os  v1.1
 Mozilla build ID:20130730070228
 
 
 Created an attachment (id=482493)
 log
 
 DEFECT DESCRIPTION:
  The contacts were disappeared,when you import many contacts from Gmail
 
  REPRODUCING PROCEDURES:
  1.There are many contacts at Gmail(almost 100 contacts)
  2.Launch Contacts->Contacts setting->Press Gmail
  3.Log in Gmail->Select all->Import contacts from Gmail
  4.Long press Home key->kill Contacts app
  5.Reopen Contacts->The contacts were disappeared--->KO
 
  EXPECTED BEHAVIOUR:
  The contacts should not disappear
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  Mid
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[Cheng-An, XIONG]

Attachment: reproduce video

Comment 3

[Gregor Wagner [:gwagner]]

Could you please provide the logcat?

Comment 4

[buri.blff]

Attachment: log.txt

Comment 5

[Gregor Wagner [:gwagner]]

I tried to reproduce it and found:
System JS : ERROR jar:file:///system/b2g/omni.ja!/components/ContactManager.js:637
                     NS_NOINTERFACE: Component does not have requested interface [nsIDOMContact.id]

Comment 6

[Gregor Wagner [:gwagner]]

But I can't reproduce the original bug. I see the contacts after restarting.

Comment 7

[dkumar]

I was not able to reproduce this issue on both Leo and Buri device.
I was able to import all the contacts and was able to view all of them after killing the app and reopening it. 
Tested both on 1.1 Moz and Com Ril
Environmental Variables
Build ID: 20130809041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/45480132106b
Gaia: c9d0901564cf6f50e375ab48e4124b8378a2e246
Platform Version: 18.1

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

can reporter provide more information?

Comment 9

[buri.blff]

we find the ContactDB.jsm b.properties[sortBY[yInDex]] is undefined

you can test with account:
[e-mail]
chencheng
to test this pr;

Comment 10

[buri.blff]

you can reproduce this pr;

the b.properties[sortBY[yInDex]] only has 'name' and 'givenName'

Comment 11

[Gregor Wagner [:gwagner]]

(In reply to buri.blff from comment #9)
> we find the ContactDB.jsm b.properties[sortBY[yInDex]] is undefined
> 
> you can test with account:
> [e-mail]
> chencheng
> to test this pr;

Thanks a lot! We will take a look.

Comment 12

[Gregor Wagner [:gwagner]]

Hm the test account requires an identity verification.

It looks like you're signing in from an unusual location. For your protection, please help us verify your identity. Learn more. 
' Enter a verification code sent to your mobile phone •••••••••95. '

Comment 13

[Alex Keybl [:akeybl]]

(In reply to Gregor Wagner [:gwagner] from comment #12)
> Hm the test account requires an identity verification.
> 
> It looks like you're signing in from an unusual location. For your
> protection, please help us verify your identity. Learn more. 
> ' Enter a verification code sent to your mobile phone •••••••••95. '

Are you suggesting this is unsupported? If you're not sure, please needinfo [e-mail]

Comment 14

[Gregor Wagner [:gwagner]]

(In reply to Alex Keybl [:akeybl] from comment #13)
> (In reply to Gregor Wagner [:gwagner] from comment #12)
> > Hm the test account requires an identity verification.
> > 
> > It looks like you're signing in from an unusual location. For your
> > protection, please help us verify your identity. Learn more. 
> > ' Enter a verification code sent to your mobile phone •••••••••95. '
> 
> Are you suggesting this is unsupported? If you're not sure, please needinfo
> [e-mail]

It should work. I can't use the testaccount.
Leo, could you provide a testcase?

Comment 15

[Joe Cheng [:jcheng] (please needinfo)]

i can reproduce with partner build easily on this but it does not seem like people can reproduce with non-partner build.

can you confirm this bug with a build without any contacts modification on your side? Thanks

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

i flashed a moz build dated 20130813 on a buri device. i cannot reproduce either

Comment 17

[Julien Wajsberg [:julienw]]

It seems that the bug where the line quoted in comment 9 was fixed in security bug 856042 (ensuring the value is not undefined before accessing it).

(and I guess the error was not exactly the one quoted but rather there was [0] in the end)

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

If we can't reproduce on non-partner builds then marking POVB and mozilla-triage since we wouldn't block on this.

Comment 19

[Jason Smith [:jsmith]]

Switching to qawanted - can someone confirm this only reproduces on a partner build and not on non-partner builds? If so, I think we've got the information we need to move forward here.

Comment 20

[Sarah Parsons]

Unable to reproduce on Leo Build ID: 20130819041202

Environmental Variables
Build ID: 20130819041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/285e2afe2a3b
Gaia: 124ed9737f0f44781cb75f763468f1574f753ac0
Platform Version: 18.1
RIL Version: 01.01.00.019.196 

Also unable to reproduce on Partner build with base version: v08o

Build ID: 20130802164042
Gecko: /rev/
Gaia: 402e0921f78e5e93bbffb7c67c6b32164df14692
Platform Version: 18.1

Comment 21

[Jason Smith [:jsmith]]

Buri - We need a test account that reproduces this bug that has identity verification disabled. Can you provide that? We can't reproduce this on our end right now.

Comment 22

[buri.blff]

we find the dom/contacts/fallback/ContactDB.jsm

1  in getCatchedForQuery:

a.properties[sortBY[yIndex]] and b.properties[sortBY[yIndex]] crashed.

    we modify as follow:
    
    !!a.properties[sortBY[yIndex]] and !!b.properties[sortBY[yIndex]] to make sure these is neither undefined nor null;
2  aFailureCb is undefined
   we add an if asfollow:
   function (aErrorMsg) {if(aFailureCb && typeof(aFailureCb) === 'function') aFailureCb(aErrorMsg);}

so this pr can be closed.

Comment 23

[Jason Smith [:jsmith]]

Buri - If you know how to fix this and it's the gecko core code, can you provide a patch here?

Comment 24

[Julien Wajsberg [:julienw]]

1. there is no chance this fixes anything... Could you please give us your copy of ContactDB.jsm _before_ the change ?

2. I agree we have a problem with aFailureCb but that does not trigger a bug since it happens only when we already have a problem. I thought I filed a bug about this but I can't find it now.

Comment 25

[Joe Cheng [:jcheng] (please needinfo)]

Hi Amelie, can you provide the ContactDB.jsm per comment 24? thanks

clear the blocking flag for now since it does not impact any builds. please renom if this was found to be a serious problem later