902828 - [Costcontrol] In datalimit more than 5 digit numbers are entered,can not distinguish between GB/MB

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

Description

[Leo]

1. Title : In datalimit more than 5 digit numbers are entered,can not distinguish between GB/MB
2. Precondition : 
3. Tester's Action : Usage ->Welcome -> Data Report -> Data Alert check / When use is above
4. Detailed Symptom (ENG.) :In datalimit more than 5 digit numbers are entered,can not distinguish between GB/MB and GB/MB disappears
6.Reproducibility: Y
1)Frequency Rate : 100%\
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 0d5a9a7577f16b6a72a982148c6f509ee1714ea2(Gecko-499c1f8ea7ad0cdaa7086214278e2944b8a2ea33)
9.Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Screenshots attached

Comment 2

[Leo]

Attachment: Screenshots attached

Comment 3

[Leo]

.settings li > .end button .tag {
  margin: 0;
  float: none;
  height: auto;
  width: auto;
  white-space: nowrap;
}

After adding the "white-space: nowrap;" the number becomes elipsis..
Is it correct solution? or
We need to show number..unit(78.55..GB)

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Could we create a class for this, instead of the nested selectors?

Will be more effective.

Comment 5

[Leo]

You mean to say like this 

.unit {
  white-space: nowrap;
}

Here i added "unit" as class
<div class="end buttons-list">
                <button class="settings-option icon icon-dialog" data-widget-type="data-limit" data-disable-on="dataLimit=false">
                  <span class="tag unit"></span>
                </button>
              </div>

Comment 6

[Leo]

This issue depends on the bug-892086.
This issue will occur in Costcontrol FTE and also in costcontrol settings.
Bug-892086 the patch is proposed like long buttons and same way we need to do it for FTE costcontrol view also?

Comment 7

[Salvador de la Puente González [:salva]]

Bug 892086 has been solved but it remains to solve the problem in the FTE. Let's use this bug for that.

Comment 8

[Salvador de la Puente González [:salva]]

Attachment: Changing size of data limit thresholds inside the FTE

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 792217 [details]
Changing size of data limit thresholds inside the FTE

Nice, clean and direct to the point.

Comment 10

[Salvador de la Puente González [:salva]]

Master: c5f368518ae92caaa3ec822d53bcb45e1b0601c5

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted c5f368518ae92caaa3ec822d53bcb45e1b0601c5 to:
v1-train: 431e54db374f15dfb35291dea5b0839e11f10be8

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 431e54db374f15dfb35291dea5b0839e11f10be8

Comment 13

[sbogati]

Issue no longer occurs on Leo device 
Build ID: 20130827041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/328b3b8158ee
Gaia: 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1
Platform Version: 18.1
In data limit more than 5 digit numbers are entered,does distinguish between GB/MB