902839 - [dev][stage] Signature summary does not load on report/list pages

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Matt Brandt [:mbrandt]]

Steps to reproduce:
1. goto https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-08-07&signature=nsHttpConnection%3A%3A~nsHttpConnection%28%29&version=Firefox%3A25.0a1

Expected:
The page loads without errors, including the graph.

Actual:
The graph does not load and 

[10:46:06.732] GET https://crash-stats.allizom.org/signature_summary/json_data?range_value=7&range_unit=days&signature=nsHttpConnection%3A%3A%7EnsHttpConnection%28%29&version=Firefox:25.0a1&date=2013-08-07 [HTTP/1.1 500 INTERNAL SERVER ERROR 351ms]

Comment 1

[Peter Bengtsson [:peterbe]]

Here's most likely the exception 
https://errormill.mozilla.org/webtools/socorro-dev/group/65718/ although that's from dev and not stage. 

I'm investigating.

Comment 2

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla/socorro/pull/1392

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d120ecf17f56924e1238c27e16c8f2e0fdc3b36e
fixes bug 902839 - signature summary untested on product_list, r=selenamarie

Comment 4

[Matt Brandt [:mbrandt]]

Reopening:

A portion of the behavior still appears to be occurring, the #summary tab briefly displays it's data before it flashes away. Note the js errors are no longer present.

http://screencast.com/t/l5CJM2V2z

https://crash-stats-dev.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-08-11&signature=SetWindowLongPtrWHook%28HWND__*%2C+int%2C+__int64%29&version=Firefox%3A26.0a1

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa - screenshot of bug on stage

https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-08-12&signature=SetWindowLongPtrWHook%28HWND__*%2C+int%2C+__int64%29&version=Firefox%3A26.0a1


Very curious, the summary section is loading but ..
1. without full data
2. the table stylization is off

Comment 6

[Matt Brandt [:mbrandt]]

I should note that comment 5 is for stage only - the signature summary section does not load on stage. See video in comment 4.

Comment 7

[Selena Deckelmann :selenamarie :selena]

We probably have to backfill to get this to work. I'll backfill 7 days on stage and see if that fixes it.

Comment 8

[Matt Brandt [:mbrandt]]

(In reply to Selena Deckelmann :selenamarie :selena from comment #7)
> We probably have to backfill to get this to work. I'll backfill 7 days on
> stage and see if that fixes it.

Thanks Selena.

If this is due to a lack of data should the UI fail more gracefully?

Comment 9

[Selena Deckelmann :selenamarie :selena]

(In reply to Matt Brandt [:mbrandt] from comment #8)
> (In reply to Selena Deckelmann :selenamarie :selena from comment #7)
> > We probably have to backfill to get this to work. I'll backfill 7 days on
> > stage and see if that fixes it.
> 
> Thanks Selena.
> 
> If this is due to a lack of data should the UI fail more gracefully?

Yeah, that's a good point. The queries that ran before could return no results, but it was pretty unlikely.

I'm not sure where to implement that -- maybe :peterbe or :brandonsavage can weigh in on what the middleware implementation should provide if no data is found for a date range.

Comment 10

[Peter Bengtsson [:peterbe]]

If the UI doesn't do a good job of saying "Sorry. No data found" even though nothing is wrong then that has to become a new follow up bug to improve the UI. Really good point though Matt!

Comment 11

[Selena Deckelmann :selenamarie :selena]

Backfill was completed, and as soon as a portion of the data was available, signature summaries re-appeared.

Comment 12

[Peter Bengtsson [:peterbe]]

Sorry. Still SQL errors.
https://errormill.mozilla.org/webtools/socorro-dev/group/76125/

Comment 13

[Selena Deckelmann :selenamarie :selena]

This was due to a lack of migration on stage. I've got a ticket open to automate migrations in the future.

Comment 14

[Matt Brandt [:mbrandt]]

Nicely done - QA verified on stage. Summary tab correctly shows data

https://crash-stats.allizom.org/report/list?product=Thunderbird&range_value=7&range_unit=days&date=2013-08-15&signature=mozalloc_abort%28char+const*+const%29+|+NS_DebugBreak_P+|+AbortIfOffMainThreadIfCheckFast+|+nsCycleCollector%3A%3AForget2%28nsPurpleBufferEntry*%29&version=Thunderbird%3A17.0.8esr

https://crash-stats.allizom.org/report/list?product=B2G&range_value=7&range_unit=days&date=2013-08-12&signature=nsXPTCStubBase%3A%3AQueryInterface%28nsID+const%26%2C+void**%29&version=B2G%3A25.0a1

https://crash-stats.allizom.org/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-08-12&signature=SetWindowLongPtrWHook%28HWND__*%2C+int%2C+__int64%29&version=Firefox%3A26.0a1