902932 - Regression: Unable to tap an add-on to access associated options

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Aaron Train [:aaronmt]]

A regression in recent Add-Ons manager changes has resulted in basic Add-On Manager functionality at loss. Currently when one long-taps an add-on one is unable to access the context-menu associated with disabling and uninstalling an add-on.

--
Nightly (08/08)
HTC One (Android 4.2) | Samsung Galaxy S4 (Android 4.3)

Comment 1

[Aaron Train [:aaronmt]]

Mixed this up, I meant the single-tap roll-out options list.

Comment 2

[Aaron Train [:aaronmt]]

When I long-tap an add-on

E/GeckoConsole(13789): [JavaScript Warning: "WARN addons.manager: Exception calling callback: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/aboutAddons.js :: getAddons/< :: line 261"  data: no]" {file: "chrome://browser/content/aboutAddons.js" line: 261}]
E/GeckoConsole(13789): [JavaScript Error: "TypeError: document.getElementById(...) is null" {file: "chrome://browser/content/aboutAddons.js" line: 64}]

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

When tapping on an add-on row:

E/GeckoConsole(19190): [JavaScript Error: "defaultButton is null" {file: "chrome://browser/content/aboutAddons.js" line: 352}]

Comment 4

[Chris Kitching [:ckitching]]

Attachment: Remove the offending code.

It appears the latest version of the part 3 patch from bug 892113 that I uploaded is not the latest one I created.
Due to this error, not all of the code that ought to have been deleted from aboutAddons.js was deleted, and the leftovers are now complaining about the nonexistence of that which has been deleted (The objective was to remove the old search engine customisation functionality from aboutAddons.js, as it is now obsolete.)

Here's a patch to finish the job. Sorry about that. Turns out that stupid things happen when I attempt to rush a patch into a release.

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 787812 [details] [diff] [review]
Remove the offending code.

Review of attachment 787812 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about that - I thought I reviewed these changes already too, but it's also my fault for not noticing that the patch was missing parts.

This looks good, and building and testing this, none of the errors from before are present anymore.

Comment 6

[Chenxia Liu [:liuche]]

landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/5446f1cddcaf

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/5446f1cddcaf