Fix test TODO left over from bug 853388

NEW
Unassigned

Status

()

Toolkit
Add-ons Manager
4 years ago
4 years ago

People

(Reporter: Irving, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Bug 853388 left behind one unresolved test case, involving the intersection between updating addons (without changing the addon version number), rebuilding the addon database and handling compatibility overrides from AMO.

See https://bugzilla.mozilla.org/show_bug.cgi?id=853388#c31 and following comments (mostly #c32 and #c33).

My most recent thought on this issue is: If there is a compatibility update from AMO, shouldn't the cached .json file we create for the staged add-on contain that information? I'm not sure it does in this test case.
Flags: needinfo?(dtownsend+bugmail)
Depends on: 610740
(In reply to :Irving Reid from comment #0)
> Bug 853388 left behind one unresolved test case, involving the intersection
> between updating addons (without changing the addon version number),
> rebuilding the addon database and handling compatibility overrides from AMO.
> 
> See https://bugzilla.mozilla.org/show_bug.cgi?id=853388#c31 and following
> comments (mostly #c32 and #c33).
> 
> My most recent thought on this issue is: If there is a compatibility update
> from AMO, shouldn't the cached .json file we create for the staged add-on
> contain that information? I'm not sure it does in this test case.

Yes it should, I'm pretty sure it does too. The question is whether that compatibility update makes it into the DB if the DB is getting rebuilt during the same startup that the add-on is getting installed.
Flags: needinfo?(dtownsend+bugmail)
You need to log in before you can comment on or make changes to this bug.