Last Comment Bug 902950 - Fix test TODO left over from bug 853388
: Fix test TODO left over from bug 853388
Status: NEW
:
Product: Toolkit
Classification: Components
Component: Add-ons Manager (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
: Andy McKay [:andym]
Mentors:
Depends on: 610740 853388
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-08 08:41 PDT by :Irving Reid (No longer working on Firefox)
Modified: 2013-08-15 15:36 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description User image :Irving Reid (No longer working on Firefox) 2013-08-08 08:41:16 PDT
Bug 853388 left behind one unresolved test case, involving the intersection between updating addons (without changing the addon version number), rebuilding the addon database and handling compatibility overrides from AMO.

See https://bugzilla.mozilla.org/show_bug.cgi?id=853388#c31 and following comments (mostly #c32 and #c33).

My most recent thought on this issue is: If there is a compatibility update from AMO, shouldn't the cached .json file we create for the staged add-on contain that information? I'm not sure it does in this test case.
Comment 1 User image Dave Townsend [:mossop] 2013-08-15 15:36:53 PDT
(In reply to :Irving Reid from comment #0)
> Bug 853388 left behind one unresolved test case, involving the intersection
> between updating addons (without changing the addon version number),
> rebuilding the addon database and handling compatibility overrides from AMO.
> 
> See https://bugzilla.mozilla.org/show_bug.cgi?id=853388#c31 and following
> comments (mostly #c32 and #c33).
> 
> My most recent thought on this issue is: If there is a compatibility update
> from AMO, shouldn't the cached .json file we create for the staged add-on
> contain that information? I'm not sure it does in this test case.

Yes it should, I'm pretty sure it does too. The question is whether that compatibility update makes it into the DB if the DB is getting rebuilt during the same startup that the add-on is getting installed.

Note You need to log in before you can comment on or make changes to this bug.