902956 - Preserve unknown fields in XPI JSON database

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[:Irving Reid (No longer working on Firefox)]

One of the side goals for bug 853388 was to make the JSON datastore more permissive about preserving unknown attributes stored in the database; this could make us more flexible in handling multiple versions of FF sharing the same profile (for example, a developer who switches between versions, or someone who downgrades FF).

My initial thought for implementing this is to keep the DB data in a separate object as read from the database, and auto-generate getters and setters for the known fields when we create the DBAddonInternal. At the same time, we can make the setter compare the new value to the existing and automatically trigger the DeferredSave if the value changes.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

It would be good for XPIDatabase and AddonRepository to have the same mechanism for doing this - whether that means doing the same here, or modifying AddonRepository to fit what ends up being done here.

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.