903065 - LayersLogging.cpp:186:10: warning: enumeration value 'FILTER_GOOD' not handled in switch [-Wswitch]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 897532 added a new enum-value "FILTER_GOOD":
  http://hg.mozilla.org/mozilla-central/rev/d10581fd8202#l5.13
...but it missed at least one switch statement, in LayersLogging.cpp, and hence we now spam this build warning:
{
gfx/layers/LayersLogging.cpp:186:10: warning: enumeration value 'FILTER_GOOD' not handled in switch [-Wswitch]
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Trivial fix - looks like this switch statement is just stringifying the enum value, which is easy enough to do.

Comment 2

[Daniel Holbert [:dholbert]]

Note that the bug that introduced this warning (bug 897532) was backed out, for intermittent crashes, and it hasn't yet been re-landed.

(jrmuizel, feel free to just fold this into that bug's patch when you re-land, if you like.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0edc6cbac2b1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0edc6cbac2b1