LayersLogging.cpp:186:10: warning: enumeration value 'FILTER_GOOD' not handled in switch [-Wswitch]

RESOLVED FIXED in mozilla26

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla26
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 897532 added a new enum-value "FILTER_GOOD":
  http://hg.mozilla.org/mozilla-central/rev/d10581fd8202#l5.13
...but it missed at least one switch statement, in LayersLogging.cpp, and hence we now spam this build warning:
{
gfx/layers/LayersLogging.cpp:186:10: warning: enumeration value 'FILTER_GOOD' not handled in switch [-Wswitch]
}
Posted patch trivial fixSplinter Review
Trivial fix - looks like this switch statement is just stringifying the enum value, which is easy enough to do.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #787697 - Flags: review?(jmuizelaar)
OS: Linux → All
Hardware: x86_64 → All
Blocks: buildwarning
Note that the bug that introduced this warning (bug 897532) was backed out, for intermittent crashes, and it hasn't yet been re-landed.

(jrmuizel, feel free to just fold this into that bug's patch when you re-land, if you like.)
Attachment #787697 - Flags: review?(jmuizelaar) → review+
Whiteboard: [shouldn't land until bug 897532 is re-landed]
https://hg.mozilla.org/integration/mozilla-inbound/rev/0edc6cbac2b1
Flags: in-testsuite-
Whiteboard: [shouldn't land until bug 897532 is re-landed]
https://hg.mozilla.org/mozilla-central/rev/0edc6cbac2b1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.