903080 - Move CSP tests in content/base/test into a subdir

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

There's some 70 of those; probably worth separating them.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Move CSP tests in content/base/test into a subdir;

Comment 2

[David Dahl :ddahl]

Comment on attachment 791822 [details] [diff] [review]
Move CSP tests in content/base/test into a subdir;

Review of attachment 791822 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, all tests and all content tests pass.

::: content/base/test/csp/moz.build
@@ +1,5 @@
> +# -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-
> +# vim: set filetype=python:
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.

I assume the moz.build file just has to exist to tell the build system to work with this directory? sorry for my ignorance here.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 791822 [details] [diff] [review]
Move CSP tests in content/base/test into a subdir;

>diff --git a/content/base/test/moz.build b/content/base/test/moz.build
>--- a/content/base/test/moz.build
>+++ b/content/base/test/moz.build
>@@ -1,15 +1,19 @@
> # -*- Mode: python; c-basic-offset: 4; indent-tabs-mode: nil; tab-width: 40 -*-
> # vim: set filetype=python:
> # This Source Code Form is subject to the terms of the Mozilla Public
> # License, v. 2.0. If a copy of the MPL was not distributed with this
> # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> 
>-DIRS += ['chrome', 'websocket_hybi']
>+DIRS += [
>+    'chrome',
>+    'csp',
>+    'websocket_hybi'
>+]

nit: Add trailing comma to 'websocket_hybi', to match multi-line style.

moz.build/Makefile changes look good to me.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/8d77363afb16