Closed Bug 903106 Opened 13 years ago Closed 13 years ago

ref_fuzz5 crashes Nightly [xul!mozilla::dom::HTMLTableRowElement::GetSection+0x12]

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Windows 8
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: geeknik, Assigned: smaug)

References

(Blocks 1 open bug, )

Details

(Keywords: crash, csectype-nullptr, reporter-external, Whiteboard: [reporter-external])

Crash Data

Attachments

(3 files)

Attached file Windbg log file —
I was using ref_fuzz5.html to fuzz the latest Win64 Nightly build, and I managed to catch a crash with WinDBG. Happens after about 30-60 seconds of running it. I've uploaded it and the log file. I'm also using the security flag until someone else can come along and determine that this isn't an exploitable issue. [JavaScript Warning: "Expected ':' but found 'eval('. Declaration dropped." {file: "file:///D:/cross_fuzz_v3/ref_fuzz5.html" line: 0 column: 9 source: "function eval() {"}] (1bd0.1444): Access violation - code c0000005 (first chance) First chance exceptions are reported before any exception handling. This exception may be expected and handled. xul!mozilla::dom::HTMLTableRowElement::GetSection+0x12: 000007fa`12d60576 488b4820 mov rcx,qword ptr [rax+20h] ds:00000000`00000020=???????????????? FAULTING_IP: xul!mozilla::dom::HTMLTableRowElement::GetSection+12 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\content\html\content\src\htmltablerowelement.cpp @ 55] 000007fa`12d60576 488b4820 mov rcx,qword ptr [rax+20h] EXCEPTION_RECORD: ffffffffffffffff -- (.exr 0xffffffffffffffff) .exr 0xffffffffffffffff ExceptionAddress: 000007fa12d60576 (xul!mozilla::dom::HTMLTableRowElement::GetSection+0x0000000000000012) ExceptionCode: c0000005 (Access violation) ExceptionFlags: 00000000 NumberParameters: 2 Parameter[0]: 0000000000000000 Parameter[1]: 0000000000000020 Attempt to read from address 0000000000000020 FAULTING_THREAD: 0000000000001444 PROCESS_NAME: firefox.exe ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at 0x%08lx referenced memory at 0x%08lx. The memory could not be %s. EXCEPTION_CODE: (NTSTATUS) 0xc0000005 - The instruction at 0x%08lx referenced memory at 0x%08lx. The memory could not be %s. EXCEPTION_PARAMETER1: 0000000000000000 EXCEPTION_PARAMETER2: 0000000000000020 READ_ADDRESS: 0000000000000020 FOLLOWUP_IP: xul!mozilla::dom::HTMLTableRowElement::GetSection+12 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\content\html\content\src\htmltablerowelement.cpp @ 55] 000007fa`12d60576 488b4820 mov rcx,qword ptr [rax+20h] NTGLOBALFLAG: 70 APPLICATION_VERIFIER_FLAGS: 0 BUGCHECK_STR: APPLICATION_FAULT_NULL_CLASS_PTR_DEREFERENCE_INVALID_POINTER_READ PRIMARY_PROBLEM_CLASS: NULL_CLASS_PTR_DEREFERENCE DEFAULT_BUCKET_ID: NULL_CLASS_PTR_DEREFERENCE LAST_CONTROL_TRANSFER: from 000007fa12d606af to 000007fa12d60576 STACK_TEXT: 00000000`0045bbb8 000007fa`12d606af : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : xul!mozilla::dom::HTMLTableRowElement::GetSection+0x12 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\content\html\content\src\htmltablerowelement.cpp @ 55] 00000000`0045bbc0 000007fa`13522e0d : 00000000`00000000 00000000`00000000 00000000`11953f60 00000000`00000000 : xul!mozilla::dom::HTMLTableRowElement::SectionRowIndex+0x17 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\content\html\content\src\htmltablerowelement.cpp @ 104] 00000000`0045bbf0 000007fa`13523981 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`0045c0d8 : xul!mozilla::dom::HTMLTableRowElementBinding::get_sectionRowIndex+0x11 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\obj-firefox\dom\bindings\htmltablerowelementbinding.cpp @ 50] 00000000`0045bc20 000007fa`14ee76f8 : 00000000`11953f60 00000000`0045bd70 00000000`119fb670 00000000`39609600 : xul!mozilla::dom::HTMLTableRowElementBinding::genericGetter+0x129 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\obj-firefox\dom\bindings\htmltablerowelementbinding.cpp @ 465] 00000000`0045bc70 000007fa`14ee7996 : 00000000`0045c109 00000000`00000000 00000000`00000000 00000000`11953f60 : mozjs!js::Invoke+0x228 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 486] 00000000`0045c060 000007fa`14ee7ee8 : 00000000`00000000 00000000`0045c3c8 00000000`0045c2d1 00000000`0045c1c0 : mozjs!js::Invoke+0x156 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 536] 00000000`0045c160 000007fa`14fe4f5b : fffb8000`39609600 00000000`09edf000 fffb8000`48921a40 00000000`00000400 : mozjs!js::InvokeGetterOrSetter+0x58 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 608] 00000000`0045c1a0 000007fa`14fea19d : fffb8000`48921a40 00000000`11953f60 00000000`0045c3c8 000007fa`14efebdb : mozjs!js::Shape::get+0x7b [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\shape-inl.h @ 272] 00000000`0045c220 000007fa`14ee30a1 : 00000000`07f5370d 00000000`0045c3c8 00000000`11953f60 00000000`0045c360 : mozjs!js::GetPropertyHelper+0x87d [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\jsobj.cpp @ 4209] 00000000`0045c330 000007fa`14eeb58f : 00000000`07f5370d 00000000`0045c9c0 00000000`0045c418 00000000`39609600 : mozjs!GetPropertyOperation+0x251 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 289] 00000000`0045c3b0 000007fa`14ee1c89 : 00000000`11953f60 00000000`4ca3a6a8 00000000`4ca22400 00000000`4ca22400 : mozjs!Interpret+0x369f [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 2353] 00000000`0045c960 000007fa`14ee71ff : 00000000`0045ca68 00000000`0045ca68 00000000`543deb41 00000000`b113c746 : mozjs!js::RunScript+0x139 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 443] 00000000`0045c9a0 000007fa`14ed8b85 : 00000000`00000000 00000000`0045cac8 00000000`2369e9d0 00000000`0045ca70 : mozjs!js::ExecuteKernel+0xdf [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 631] 00000000`0045ca10 000007fa`14ed9079 : 00000000`3b2a10ae 00000000`0045cf20 00000000`00000004 00000000`053230d9 : mozjs!EvalKernel+0x475 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\builtin\eval.cpp @ 331] 00000000`0045cb90 000007fa`14eebeac : 00000000`05323170 00000000`05323170 00000000`053230d9 00000000`4ca22400 : mozjs!js::DirectEval+0xe9 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\builtin\eval.cpp @ 455] 00000000`0045cf10 000007fa`14ee1c89 : 00000000`11953f60 00000000`0045d710 00000000`00000001 00000000`00000001 : mozjs!Interpret+0x3fbc [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 2459] 00000000`0045d4c0 000007fa`14ee782a : 00000000`0045d610 00000000`11953f60 00000000`0045d690 00000000`11953f60 : mozjs!js::RunScript+0x139 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 443] 00000000`0045d500 000007fa`14ee7996 : 00000000`0045d999 00000000`0045db70 00000000`00000002 00000000`0045da68 : mozjs!js::Invoke+0x35a [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 508] 00000000`0045d8f0 000007fa`150a1b0b : 00000000`11953f60 00000000`11953f60 00000000`0045dad8 00000000`1d7df820 : mozjs!js::Invoke+0x156 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\vm\interpreter.cpp @ 536] 00000000`0045d9f0 00000000`0072edd1 : 00000000`03052292 00000000`489b31a0 00000000`109293c0 00000000`0045db10 : mozjs!js::ion::DoCallFallback+0x24b [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\ion\baselineic.cpp @ 7051] 00000000`0045dad0 00000000`03052292 : 00000000`489b31a0 00000000`109293c0 00000000`0045db10 00000000`0045db60 : 0x72edd1 00000000`0045dad8 00000000`489b31a0 : 00000000`109293c0 00000000`0045db10 00000000`0045db60 00000000`0045db18 : 0x3052292 00000000`0045dae0 00000000`109293c0 : 00000000`0045db10 00000000`0045db60 00000000`0045db18 00000000`0045db38 : 0x489b31a0 00000000`0045dae8 00000000`0045db10 : 00000000`0045db60 00000000`0045db18 00000000`0045db38 00000000`0045db18 : 0x109293c0 00000000`0045daf0 00000000`0045db60 : 00000000`0045db18 00000000`0045db38 00000000`0045db18 00000000`11953f60 : 0x45db10 00000000`0045daf8 00000000`0045db18 : 00000000`0045db38 00000000`0045db18 00000000`11953f60 fff90000`00000000 : 0x45db60 00000000`0045db00 00000000`0045db38 : 00000000`0045db18 00000000`11953f60 fff90000`00000000 000007fa`1526cdb0 : 0x45db18 00000000`0045db08 00000000`0045db18 : 00000000`11953f60 fff90000`00000000 000007fa`1526cdb0 00000000`12e5c910 : 0x45db38 00000000`0045db10 00000000`11953f60 : fff90000`00000000 000007fa`1526cdb0 00000000`12e5c910 00000000`0b7a359f : 0x45db18 00000000`0045db18 fff90000`00000000 : 000007fa`1526cdb0 00000000`12e5c910 00000000`0b7a359f 00000000`00000502 : 0x11953f60 00000000`0045db20 000007fa`1526cdb0 : 00000000`12e5c910 00000000`0b7a359f 00000000`00000502 00000000`0045dbe8 : 0xfff90000`00000000 00000000`0045db28 00000000`12e5c910 : 00000000`0b7a359f 00000000`00000502 00000000`0045dbe8 00000000`109293c0 : mozjs!DoCallFallbackInfo 00000000`0045db30 00000000`0b7a359f : 00000000`00000502 00000000`0045dbe8 00000000`109293c0 00000000`00000002 : 0x12e5c910 00000000`0045db38 00000000`00000502 : 00000000`0045dbe8 00000000`109293c0 00000000`00000002 00000000`0045db60 : 0xb7a359f 00000000`0045db40 00000000`0045dbe8 : 00000000`109293c0 00000000`00000002 00000000`0045db60 fffb8000`48902680 : 0x502 00000000`0045db48 00000000`109293c0 : 00000000`00000002 00000000`0045db60 fffb8000`48902680 fff90000`00000000 : 0x45dbe8 00000000`0045db50 00000000`00000002 : 00000000`0045db60 fffb8000`48902680 fff90000`00000000 fffb8000`39609600 : 0x109293c0 00000000`0045db58 00000000`0045db60 : fffb8000`48902680 fff90000`00000000 fffb8000`39609600 fffa8000`45c922c0 : 0x2 00000000`0045db60 fffb8000`48902680 : fff90000`00000000 fffb8000`39609600 fffa8000`45c922c0 00000000`0045dc30 : 0x45db60 00000000`0045db68 fff90000`00000000 : fffb8000`39609600 fffa8000`45c922c0 00000000`0045dc30 00000000`109293c0 : 0xfffb8000`48902680 00000000`0045db70 fffb8000`39609600 : fffa8000`45c922c0 00000000`0045dc30 00000000`109293c0 00000000`03052292 : 0xfff90000`00000000 00000000`0045db78 fffa8000`45c922c0 : 00000000`0045dc30 00000000`109293c0 00000000`03052292 00000000`00000981 : 0xfffb8000`39609600 00000000`0045db80 00000000`0045dc30 : 00000000`109293c0 00000000`03052292 00000000`00000981 fffa8000`45c922c0 : 0xfffa8000`45c922c0 00000000`0045db88 00000000`109293c0 : 00000000`03052292 00000000`00000981 fffa8000`45c922c0 fffb8000`39609600 : 0x45dc30 00000000`0045db90 00000000`03052292 : 00000000`00000981 fffa8000`45c922c0 fffb8000`39609600 fff90000`00000000 : 0x109293c0 00000000`0045db98 00000000`00000981 : fffa8000`45c922c0 fffb8000`39609600 fff90000`00000000 fffb8000`48902680 : 0x3052292 00000000`0045dba0 fffa8000`45c922c0 : fffb8000`39609600 fff90000`00000000 fffb8000`48902680 fff90000`00000000 : 0x981 00000000`0045dba8 fffb8000`39609600 : fff90000`00000000 fffb8000`48902680 fff90000`00000000 fff90000`00000000 : 0xfffa8000`45c922c0 00000000`0045dbb0 fff90000`00000000 : fffb8000`48902680 fff90000`00000000 fff90000`00000000 fff90000`00000000 : 0xfffb8000`39609600 00000000`0045dbb8 fffb8000`48902680 : fff90000`00000000 fff90000`00000000 fff90000`00000000 fff90000`00000000 : 0xfff90000`00000000 00000000`0045dbc0 fff90000`00000000 : fff90000`00000000 fff90000`00000000 fff90000`00000000 fff90000`00000000 : 0xfffb8000`48902680 00000000`0045dbc8 fff90000`00000000 : fff90000`00000000 fff90000`00000000 fff90000`00000000 000007fa`14ef806b : 0xfff90000`00000000 00000000`0045dbd0 fff90000`00000000 : fff90000`00000000 fff90000`00000000 000007fa`14ef806b 00000000`0045dda0 : 0xfff90000`00000000 00000000`0045dbd8 fff90000`00000000 : fff90000`00000000 000007fa`14ef806b 00000000`0045dda0 00000000`00000098 : 0xfff90000`00000000 00000000`0045dbe0 fff90000`00000000 : 000007fa`14ef806b 00000000`0045dda0 00000000`00000098 00000000`4ca220a0 : 0xfff90000`00000000 00000000`0045dbe8 000007fa`14ef806b : 00000000`0045dda0 00000000`00000098 00000000`4ca220a0 fffa8000`00000000 : 0xfff90000`00000000 00000000`0045dbf0 000007fa`14ef98b6 : 00000000`2e0ea670 3ff00018`00000004 00000000`0045dd50 00000000`007287f9 : mozjs!MarkInternal<JSFunction>+0x7b [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\gc\marking.cpp @ 198] 00000000`0045dc20 00000000`48902780 : 00000000`00000000 fff90000`00000000 00000000`0045d3c8 00000000`0045de98 : mozjs!MarkValueInternal+0x96 [e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\js\src\gc\marking.cpp @ 520] 00000000`0045dc50 00000000`00000000 : fff90000`00000000 00000000`0045d3c8 00000000`0045de98 00000000`00000000 : 0x48902780 FAULTING_SOURCE_CODE: No source found for 'e:\builds\moz2_slave\m-cen-w64-ntly-000000000000000\build\content\html\content\src\htmltablerowelement.cpp' SYMBOL_STACK_INDEX: 0 SYMBOL_NAME: xul!mozilla::dom::HTMLTableRowElement::GetSection+12 FOLLOWUP_NAME: MachineOwner MODULE_NAME: xul IMAGE_NAME: xul.dll DEBUG_FLR_IMAGE_TIMESTAMP: 52014689 STACK_COMMAND: ~0s ; kb FAILURE_BUCKET_ID: NULL_CLASS_PTR_DEREFERENCE_c0000005_xul.dll!mozilla::dom::HTMLTableRowElement::GetSection BUCKET_ID: X64_APPLICATION_FAULT_NULL_CLASS_PTR_DEREFERENCE_INVALID_POINTER_READ_xul!mozilla::dom::HTMLTableRowElement::GetSection+12 WATSON_STAGEONE_URL: http://watson.microsoft.com/StageOne/firefox_exe/26_0_0_4966/52014764/xul_dll/26_0_0_4966/52014689/c0000005/00540576.htm?Retriage=1 Followup: MachineOwner
Attached file ref_fuzz5.html —
Stack trace looks very much DOM
Assignee: general → nobody
Component: JavaScript Engine → DOM
But this looks like a null pointer crash.
Assignee: nobody → bugs
Whiteboard: [reporter-external]
URL: data:text/html,<script>document.creat...
Attached patch null check — — Splinter Review
Attachment #787752 - Flags: review?
Blocks: 893117
Attachment #787752 - Flags: review? → review?(dzbarsky)
dz, do we need this on Aurora too?
Group: core-security
Comment on attachment 787752 [details] [diff] [review] null check Review of attachment 787752 [details] [diff] [review]: ----------------------------------------------------------------- r=me. And yeah, we should fix this on Aurora as well.
Attachment #787752 - Flags: review?(dzbarsky) → review+
Comment on attachment 787752 [details] [diff] [review] null check [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 893117 User impact if declined: null pointer crash Testing completed (on m-c, etc.): landed to m-i Risk to taking this patch (and alternatives if risky): super safe String or IDL/UUID changes made by this patch:NA
Attachment #787752 - Flags: approval-mozilla-aurora?
Crash Signature: [@ mozilla::dom::HTMLTableRowElement::GetSection()]
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
This is a non-exploitable null dereference.
Flags: sec-bounty? → sec-bounty-
Keywords: csec-nullptr
Comment on attachment 787752 [details] [diff] [review] null check Simple null check fix, let's take it.
Attachment #787752 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: