903130 - Fix mismatched err vs. error in reportError function

Status: VERIFIED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[David Humphrey (:humph)]

function reportError( error, isFatal ) {
  if ( !graylogHost ) {
    return;
  }
  log( "[" + ( isFatal ? "CRASH" : "ERROR" ) + "] webmaker.org error",
    err.message,
    {
      level: isFatal ? LOG_CRIT : LOG_ERR,
      stack: err.stack,
      _serverVersion: require( './package.json' ).version,
      _fullStack: err.stack
    }
  );
}

This is mixing err and error, and will crash when it tries to log to the server.

Comment 1

[David Humphrey (:humph)]

Attachment: https://github.com/mozilla/webmaker.org/pull/322

Comment 2

[Chris DeCairos (:cade)]

Comment on attachment 787757 [details] [review]
https://github.com/mozilla/webmaker.org/pull/322

R+

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/3ede90df61440084d63bc61450bf5aade9336a14
Bug 903130 - Fix mismatched err vs. error in reportError function.

Comment 4

[David Humphrey (:humph)]

On prod now.