903160 - Follow-up: Use ViewStub in home_list_with_title.xml for lazy inflation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Since the empty view in home_list_with_title.xml is not set on creation, use a ViewStub to do lazy inflation.

http://developer.android.com/reference/android/view/ViewStub.html

Comment 1

[Chenxia Liu [:liuche]]

Attachment: Patch: viewstub

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 788427 [details] [diff] [review]
Patch: viewstub

Review of attachment 788427 [details] [diff] [review]:
-----------------------------------------------------------------

Super.

::: mobile/android/base/home/LastTabsPage.java
@@ +159,5 @@
>          mRestoreButton.setVisibility(View.GONE);
>  
>          if (mEmptyView == null) {
>              // Set empty page view. We delay this so that the empty view won't flash.
> +            ViewStub emptyViewStub = (ViewStub) getActivity().findViewById(R.id.home_empty_view_stub);

Please make this final.

::: mobile/android/base/home/MostRecentPage.java
@@ +158,5 @@
>          // Cursor is empty, so hide the title and set the empty view if it hasn't been set already.
>          mTitle.setVisibility(View.GONE);
>          if (mEmptyView == null) {
>              // Set empty page view. We delay this so that the empty view won't flash.
> +            ViewStub emptyViewStub = (ViewStub) getActivity().findViewById(R.id.home_empty_view_stub);

Please make this final.

Comment 3

[Chenxia Liu [:liuche]]

Forgot to drop the revision here: https://hg.mozilla.org/projects/fig/rev/dff6e98eaac0

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dff6e98eaac0