903273 - [Session Restore] Use strict mode

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Strict mode FTW. That should help us catch silly mistakes a little earlier.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Use strict mode in SessionStore files

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/742a0082788f

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/742a0082788f

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 787955 [details] [diff] [review]
Use strict mode in SessionStore files

Review of attachment 787955 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/SessionStore.jsm
@@ +881,5 @@
> +      aWindow.removeEventListener("load", onload);
> +      this.onLoad(aWindow);
> +    };
> +
> +    aWindow.addEventListener("load", onload);

Just fyi: this can also be

aWindow.addEventListener("load", function onload(aEvent) {
  //                                      ^^^^^^
  aWindow.removeEventListener("load", onload);
  // ...
}

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Ms2ger from comment #4)
> Just fyi: this can also be
> 
> aWindow.addEventListener("load", function onload(aEvent) {
>   //                                      ^^^^^^
>   aWindow.removeEventListener("load", onload);
>   // ...
> }

Well then I'd either have to '.bind(this)' and save that to a variable or do a 'let self = this' and call self.onLoad().