903293 - Remote browser constructors shouldn't try to initialize session history

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

When creating a <browser remote=true> element and injecting it, the constructor tries to initialize session history without having a docShell. As this is used by the background thumbnailing service this errors appears quite regularly.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Remote browser constructors shouldn't try to initialize session history

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 787973 [details] [diff] [review]
Remote browser constructors shouldn't try to initialize session history

I wonder if this.isRemoteBrowser should be used to better convey the intention?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 787973 [details] [diff] [review]
Remote browser constructors shouldn't try to initialize session history

Review of attachment 787973 [details] [diff] [review]:
-----------------------------------------------------------------

I think (though not certain yet) that we might remove the isRemoteBrowser in the future (because everything related to a remote browser should be in remote-browser.xml), so using docShell here is fine

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/958dd2faefcf

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/958dd2faefcf

Comment 6

[:Gavin Sharp [email: [e-mail]]]

One thing I was curious about was how session history works in remote browsers, if it isn't set up here. Anyone know? :)