Closed Bug 903311 Opened 6 years ago Closed 6 years ago

Remove support for chrome access to history[n].

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jst, Assigned: jst)

Details

(Keywords: addon-compat, dev-doc-complete)

Attachments

(1 file)

From a quick grep in the source tree it seems like there's only a handful of users of window.history[n] in our tree, and per bz's bug 859707 comment 8 the existence of the chrome only history[n] getter is detectable by web content. It's not part of the web platform, we should remove it in favor of an explicit chrome only method whose existence is not detectable by web content.
Actually, I can't find a single usage of history[n] in our whole repo. Nor can I find one in the AMO mxr. Also, seems history.current, history.previous, and history.next are also completely unused in our repo.
Johnny, do you plan to do this, or does it need another owner?
Flags: needinfo?(jst)
This is green on try, surprisingly.
Attachment #788486 - Flags: review?(bzbarsky)
Flags: needinfo?(jst)
Oh, and the attached patch applies on top of the patch in bug 859707.
Comment on attachment 788486 [details] [diff] [review]
Remove all chrome only methods from History.

Good deal!
Attachment #788486 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/8fbc8f215653

\o/
Assignee: nobody → jst
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
I see some instances of this in the Add-ons MXR, mostly from libraries.
Keywords: addon-compat
(In reply to Jorge Villalobos [:jorgev] from comment #10)
> I see some instances of this in the Add-ons MXR, mostly from libraries.

Hmm, can you share some examples? I thought I looked, and got nothing, but it was quite a while ago...

Thanks.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.