Closed Bug 903352 Opened 11 years ago Closed 11 years ago

Handlify remaining PropertyDescriptor APIs

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

handlify-gpdbi
14.42 KB, patch
terrence
: review+
Details | Diff | Splinter Review
handlify-gpdbi-xpc
15.20 KB, patch
bholley
: review+
Details | Diff | Splinter Review
handlify-gpdbi-browser
26.42 KB, patch
smaug
: review+
Details | Diff | Splinter Review
The following APIs can be converted to take handles rather than pointer/references: JS_GetPropertyDescriptorById JS_WrapPropertyDescriptor js_DefineOwnProperty
Attached patch handlify-gpdbi — — Splinter Review
Attachment #788060 - Flags: review?(terrence)
Attachment #788061 - Flags: review?(bobbyholley+bmo)
Attachment #788062 - Flags: review?(bugs)
Attachment #788061 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 788060 [details] [diff] [review] handlify-gpdbi Review of attachment 788060 [details] [diff] [review]: ----------------------------------------------------------------- \o/ r=me
Attachment #788060 - Flags: review?(terrence) → review+
Comment on attachment 788062 [details] [diff] [review] handlify-gpdbi-browser Can we now remove js::CastAsJSPropertyOp ? Nothing seems to use it anymore. http://mxr.mozilla.org/mozilla-central/source/js/src/jsfriendapi.h?rev=8b241c4e3eec#579
Attachment #788062 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c2414f44c0cc
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Blocks: 773686
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: