Closed Bug 903354 Opened 10 years ago Closed 10 years ago

GC: Remove unused AutoPropertyDescriptorRooter

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: jonco, Assigned: jonco)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

remove-apdr
3.56 KB, patch
terrence
: review+
Details | Diff | Splinter Review
Attached patch remove-apdr — — Splinter Review 
Since this is now unused we can get rid of it.
Attachment #788064 - Flags: review?(terrence)
Comment on attachment 788064 [details] [diff] [review]
remove-apdr

Review of attachment 788064 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent! \o/

r=me

::: js/src/jsobjinlines.h
@@ -933,5 @@
>  };
>  
> -class AutoPropertyDescriptorRooter : private AutoGCRooter, public PropertyDescriptor
> -{
> -    SkipRoot skip;

And another SkipRoot down!
Attachment #788064 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/9f3cb82af6fa
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.