903357 - Provide way to ship 24.0b1 updates without having win32 l10n

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

If we can't solve the win32 l10n problem (bug 902091) and don't want to delay shipping any further we need a 'Plan B' to ship updates to 24.0b1. Ideally this will be all locales for mac and linux, en-US only for win32. Once the build problem is resolved we'd go back to providing updates for all locales & platforms.

I've been working on this and will put a proposal up shortly.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: shipped-locales

With some fixes to the scripts for bumping update verify configs and snippet generation, we can use a shipped-locales like this. 'linux osx' is appended to every line except en-US, and the ja line loses the win32 reference. If we're OK to land this into mozilla-beta we can also generate updates by forcing the builder rather than manually (ie it works on my laptop).

I've pushed my working up to http://hg.mozilla.org/users/nthomas_mozilla.com/tools/, and here are the configs diffs for 
   real 24.0b1 build2 - http://people.mozilla.org/~nthomas/b1-configs
 a fake 24.0b2 build1 - http://people.mozilla.org/~nthomas/b2-configs

From a quick inspection these are sane, and the snippets to the right things for Windows. I haven't run update verify yet.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] script changes

The hunks in this patch are
* when generating snippets, also consider the exceptions in the 'to' build as well as the 'from' build
* when write an update verify config
 * skip the line if there are no locales specific
 * consider the exceptions in the 'to' build as well as the 'from' build

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 788082 [details] [diff] [review]
[tools] script changes

There's a glitch with this. The guard on len(locales) < 1 disrupts running update verify on all platforms, but if it's removed at config bump time that also causes issues.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] script changes, v2

Fixed but not pretty. The issues I was having starting win32 update verify are gone and we don't have config lines with locales="" in them.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 788124 [details] [diff] [review]
[tools] script changes, v2

lgtm

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Status - I've generated configs and snippets with these two attachments. We get only en-US snippets for windows, all locales otherwise. Spot checks on the snippets look OK, but update verify is going to be the way to flush out any issues. I've tested in staging that update verify still runs, but haven't pushed snippets anywhere so can't say more than that.

I'd suggest deployment looks like this
* land attachment 788078 [details] on mozilla-beta, move tags
* force the updates builder (but you could do this manually via your runme.sh script, just watch out for -b 1 that needs changing to -b 2)
* cross fingers & toes

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 788124 [details] [diff] [review]
[tools] script changes, v2

https://hg.mozilla.org/build/tools/rev/69b264e3fbe0

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

RESOLVED FIXED depends on how the 24.0b2 updates went, after sorting out any fallout from win32_repack 2 getting run twice.

Comment 9

[Rail Aliiev [:rail]]

done