903404 - [about:networking] Move /toolkit/content/aboutNetworking.css from content to themes

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Philip Chee]

Most if not all the CSS in aboutNetworking.css is purely presentational. Presentational CSS should go into /toolkit/themes/ to allow theme authors to skin about:networking. (did a toolkit peer go through the patch in Bug 865850 at all?)

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Philip Chee from comment #0)
> (did a toolkit peer go through the patch in Bug 865850 at all?)

No, sorry. I should've asked one, my bad. I completely forgot that we were in toolkit land for some reason :/ I don't think that any UX person has even looked at about:networking so far so I'm not sure we should spend that many time on making it themable, no?

Comment 2

[Philip Chee]

> I'm not sure we should spend that many time on making it themable, no?
True. Perhaps this would make a GFB (good first bug). Any suggestions for a suitable mentor?

Comment 3

[Stefan [:stefanh]]

(In reply to Tim Taubert [:ttaubert] from comment #1)
> (In reply to Philip Chee from comment #0)
> > (did a toolkit peer go through the patch in Bug 865850 at all?)
> 
> No, sorry. I should've asked one, my bad. I completely forgot that we were
> in toolkit land for some reason :/ I don't think that any UX person has even
> looked at about:networking so far so I'm not sure we should spend that many
> time on making it themable, no?

Comment 4

[Stefan [:stefanh]]

Sorry, accidentally hit the wrong key...

It would still look the same - moving the .css to themes (and then making it themable) won't change the look of about;networking.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Theme-ability for this page is not very important.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

We certainly shouldn't make maintaining/improving this page's styling harder by forking the style three ways. I suppose using toolkit/themes/shared would be fine.

Comment 7

[Robert Bindar]

I'm not very familiar with jar.mn manifests, I looked into the shared/ dir and I didn't see any, where should I put the "aboutNetworking.css" entry and what is the corresponding path to toolkit/shared/ dir in a jar.mn file?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

pluginProblem.css is a good example to follow. Put the file in toolkit/themes/shared, refer to it from the existing jar.mn files using relative paths.

Comment 9

[Robert Bindar]

Attachment: move_abouNet_css.patch

Comment 10

[Robert Bindar]

Thanks Gavin, it was helpful.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 789148 [details] [diff] [review]
move_abouNet_css.patch

This is in the right direction, but you'll need to move the jar.mn entry from toolkit/content/jar.mn to the OSX and Windows-specific ones in toolkit/themes (i.e. same as http://mxr.mozilla.org/mozilla-central/search?string=pluginProblem.css).

You'll also want to use "hg mv" to move the file from its old location to the new one, rather than removing and re-adding.

Comment 12

[Robert Bindar]

Attachment: move_aboutNet_css.patch

I hope the archive path it's ok.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 790128 [details] [diff] [review]
move_aboutNet_css.patch

For toolkit/themes/windows/mozapps/jar.mn, you need to add the file twice in both sections (just copy pluginProblem.css).

r=me with that change

Comment 14

[Robert Bindar]

Attachment: move_aboutNet_css.patch

Comment 15

[Robert Bindar]

Valentin, can you add checkin-needed keyword please?

Comment 16

[Robert Bindar]

Attachment: move_aboutNet_css.patch

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/9fb8a7b295e6

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9fb8a7b295e6