Closed Bug 903404 Opened 6 years ago Closed 6 years ago

[about:networking] Move /toolkit/content/aboutNetworking.css from content to themes

Categories

(Toolkit :: Themes, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: philip.chee, Assigned: robertbindar)

References

Details

(Keywords: classic, modern)

Attachments

(1 file, 3 obsolete files)

Most if not all the CSS in aboutNetworking.css is purely presentational. Presentational CSS should go into /toolkit/themes/ to allow theme authors to skin about:networking. (did a toolkit peer go through the patch in Bug 865850 at all?)
Component: Networking → Themes
Product: Core → Toolkit
(In reply to Philip Chee from comment #0)
> (did a toolkit peer go through the patch in Bug 865850 at all?)

No, sorry. I should've asked one, my bad. I completely forgot that we were in toolkit land for some reason :/ I don't think that any UX person has even looked at about:networking so far so I'm not sure we should spend that many time on making it themable, no?
> I'm not sure we should spend that many time on making it themable, no?
True. Perhaps this would make a GFB (good first bug). Any suggestions for a suitable mentor?
Assignee: nobody → valentin.gosu
(In reply to Tim Taubert [:ttaubert] from comment #1)
> (In reply to Philip Chee from comment #0)
> > (did a toolkit peer go through the patch in Bug 865850 at all?)
> 
> No, sorry. I should've asked one, my bad. I completely forgot that we were
> in toolkit land for some reason :/ I don't think that any UX person has even
> looked at about:networking so far so I'm not sure we should spend that many
> time on making it themable, no?
Sorry, accidentally hit the wrong key...

It would still look the same - moving the .css to themes (and then making it themable) won't change the look of about;networking.
Theme-ability for this page is not very important.
We certainly shouldn't make maintaining/improving this page's styling harder by forking the style three ways. I suppose using toolkit/themes/shared would be fine.
I'm not very familiar with jar.mn manifests, I looked into the shared/ dir and I didn't see any, where should I put the "aboutNetworking.css" entry and what is the corresponding path to toolkit/shared/ dir in a jar.mn file?
pluginProblem.css is a good example to follow. Put the file in toolkit/themes/shared, refer to it from the existing jar.mn files using relative paths.
Attached patch move_abouNet_css.patch (obsolete) — Splinter Review
Attachment #789148 - Flags: review?(valentin.gosu)
Attachment #789148 - Flags: review?(gavin.sharp)
Thanks Gavin, it was helpful.
Comment on attachment 789148 [details] [diff] [review]
move_abouNet_css.patch

This is in the right direction, but you'll need to move the jar.mn entry from toolkit/content/jar.mn to the OSX and Windows-specific ones in toolkit/themes (i.e. same as http://mxr.mozilla.org/mozilla-central/search?string=pluginProblem.css).

You'll also want to use "hg mv" to move the file from its old location to the new one, rather than removing and re-adding.
Attachment #789148 - Flags: review?(valentin.gosu)
Attachment #789148 - Flags: review?(gavin.sharp)
Attachment #789148 - Flags: review-
Attached patch move_aboutNet_css.patch (obsolete) — Splinter Review
I hope the archive path it's ok.
Attachment #789148 - Attachment is obsolete: true
Attachment #790128 - Flags: review?(valentin.gosu)
Attachment #790128 - Flags: review?(gavin.sharp)
Comment on attachment 790128 [details] [diff] [review]
move_aboutNet_css.patch

For toolkit/themes/windows/mozapps/jar.mn, you need to add the file twice in both sections (just copy pluginProblem.css).

r=me with that change
Attachment #790128 - Flags: review?(gavin.sharp) → review+
Attached patch move_aboutNet_css.patch (obsolete) — Splinter Review
Attachment #790128 - Attachment is obsolete: true
Attachment #790128 - Flags: review?(valentin.gosu)
Valentin, can you add checkin-needed keyword please?
Assignee: valentin.gosu → robertbindar
Attachment #791263 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9fb8a7b295e6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.