903405 - [E.me][L10n] After changing language, the description in e.me should change

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[Al Tsai [:atsai]]

As a user, the sentences and titles in e.me should change as I change the default system language from settings.


Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/1433d653b701
Gaia   5cb67ea419b0a642ea11b6c8f93c3ee50318e90a
BuildID 20130808041202
Version 18.0

Comment 1

[Al Tsai [:atsai]]

STR:
1. changes to Spanish from settings
2. Back to homescreen

Expect Result:
*) The default sentence should change to Spanish

Actual Result:
*) It's still English

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This is likely because the localization is ongoing. For the moment some strings are only in english.

Comment 3

[Leo]

This is reproduced on current build 9/16 of v1-train. We think that the localization issue is very important to end-users. Please fix it before launching.

Comment 4

[Wayne Chang [:wchang]]

Axel,

Not sure if you're also helping with the e.me localisation?

Comment 5

[Axel Hecht [:Pike]]

We're having the strings for at least some of e.me, but for things like what needs to happen on language switching in an app, I can't be of much help. This will need care from folks that actually know the e.me code.

Comment 6

[Cristian Rodriguez (:crdlc)]

Hi Ran, could you take a look to this one?

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR.html

Comment 8

[Cristian Rodriguez (:crdlc)]

Comment on attachment 805276 [details]
Patch - redirect to github PR.html

Perfect!

Comment 9

[Beatriz Rodríguez [:brg]]

Thanks everyone for your fast response!

Comment 10

[Leo]

After applying the patch, the localization issue is reproduced. As you know, we can't merge all the gaia sources on leo device. So I only merged homescreen application. Do I need to merge another patch to fix it? Please let me know.

Comment 11

[Ran Ben Aharon [:ranbena] EverythingMe]

Not that I know of. The fix is for one typo. Should work with no dependencies.
Did you apply this to latest v1-train?

Comment 12

[Leo]

If I merged all the latest gaia, it works well. But We are using old version like taht. 

Gaia : 0d5a9a7577f16b6a72a982148c6f509ee1714ea2
Gecko : 499c1f8ea7ad0cdaa7086214278e2944b8a2ea33

Please help us.

Comment 13

[Ran Ben Aharon [:ranbena] EverythingMe]

I'm sorry Leo but I don't understand what's needed. You say it works well?

Comment 14

[Leo]

I'm so sorry. It's my mistake to merge homescreen sources. Now it works well. 
Thank you for your help.

Comment 15

[Wayne Chang [:wchang]]

This has leo+, adding check-in needed (am i using this wrong?)

Comment 17

[Ryan VanderMeulen [:RyanVM]]

John, can you assist please? :)

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

[v1.2 06956e4]
[v1-train 87eb458]

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 87eb458aa95afda97ae99aa101819c01a0e15f66

Comment 20

[Ran Ben Aharon [:ranbena] EverythingMe]

Due to a regression - reapplied to current master
https://github.com/mozilla-b2g/gaia/commit/79cc970a9aca9c1f0888c70b60687b87a8871c32

Comment 21

[Gregor Wagner [:gwagner]]

Lets keep it with leo+ and land in all channels.