make ConstantSpecs in OSFileConstants.cpp const and constexpr-foldable

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
Created attachment 788135 [details] [diff] [review]
make ConstantSpecs in OSFileConstants.cpp const and constexpr-foldable

The JSVAL_VOID -> JS::UndefinedValue() change is so that all the jsvals are constexpr.
GCC will not eliminate the static constructor without that change.
Attachment #788135 - Flags: review?(bugs)
(Reporter)

Comment 2

5 years ago
Comment on attachment 788135 [details] [diff] [review]
make ConstantSpecs in OSFileConstants.cpp const and constexpr-foldable

Review of attachment 788135 [details] [diff] [review]:
-----------------------------------------------------------------

khuey r+'d this on IRC.
Attachment #788135 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/afbed604db04
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.