Closed Bug 903427 Opened 8 years ago Closed 8 years ago

make ConstantSpecs in OSFileConstants.cpp const and constexpr-foldable

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(1 file)

No description provided.
The JSVAL_VOID -> JS::UndefinedValue() change is so that all the jsvals are constexpr.
GCC will not eliminate the static constructor without that change.
Attachment #788135 - Flags: review?(bugs)
Comment on attachment 788135 [details] [diff] [review]
make ConstantSpecs in OSFileConstants.cpp const and constexpr-foldable

Review of attachment 788135 [details] [diff] [review]:
-----------------------------------------------------------------

khuey r+'d this on IRC.
Attachment #788135 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/afbed604db04
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.