903434 - Fullscreen app manifest property should be using direct booleans, not strings

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jason Smith [:jsmith]]

Per the discussion on bug 903165, the app manifest spec wants direct booleans used, not strings, to define boolean-based values. As a result, the fullscreen app manifest property is currently implemented incorrectly - it should be using true instead of "true."

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Agreed. We can keep compat with the old syntax if we really need to by simply checking the type (string vs. boolean)

Comment 2

[Marco Castelluccio [:marco]]

The info here is a little confusing: https://developer.mozilla.org/en-US/docs/Web/Apps/Manifest#fullscreen

Comment 3

[Mark Giffin [:markg]]

I changed the fullscreen docs to use a true boolean:

https://developer.mozilla.org/en-US/docs/Web/Apps/Manifest#fullscreen

Comment 4

[tlhunter]

(In reply to Mark Giffin [:markg] from comment #3)
> I changed the fullscreen docs to use a true boolean:
> 
> https://developer.mozilla.org/en-US/docs/Web/Apps/Manifest#fullscreen

Looks like it has been reverted back to a string:

https://developer.mozilla.org/en-US/Apps/Build/Manifest#fullscreen

Comment 5

[tlhunter]

It looks like the reason the documentation is using a string for fullscreen instead of a boolean is because the packaged app validator (and probably Firefox OS) also requires it to be a string (which is of course a bug).

Comment 6

[BMO Automation]

Firefox OS is not being worked on