903455 - WebGL2 transform feedback - RASTERIZER_DISCARD

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Guillaume Abadie]

Implement the WebGL 2 feature EXT_transform_feedback

Comment 1

[Guillaume Abadie]

Attachment: patch revision 1

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 788254 [details] [diff] [review]
patch revision 1

Review of attachment 788254 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.h
@@ +762,5 @@
> +    JS::Value GetParameter(JSContext* cx, WebGLenum pname, ErrorResult& rv);
> +    bool IsEnabled(WebGLenum cap);
> +
> +private:
> +    bool ValidateCapabilityEnum(WebGLenum cap, const char *info);

* to the left, since something else in this section does it.

Comment 3

[Guillaume Abadie]

(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 788254 [details] [diff] [review]
> patch revision 1
> 
> Review of attachment 788254 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/canvas/src/WebGLContext.h
> @@ +762,5 @@
> > +    JS::Value GetParameter(JSContext* cx, WebGLenum pname, ErrorResult& rv);
> > +    bool IsEnabled(WebGLenum cap);
> > +
> > +private:
> > +    bool ValidateCapabilityEnum(WebGLenum cap, const char *info);
> 
> * to the left, since something else in this section does it.
Fixed.
Thanks!

Comment 4

[Guillaume Abadie]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e679d59f1437

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e679d59f1437