Closed Bug 903455 Opened 6 years ago Closed 6 years ago

WebGL2 transform feedback - RASTERIZER_DISCARD

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: guillaume.abadie, Assigned: guillaume.abadie)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Implement the WebGL 2 feature EXT_transform_feedback
Blocks: 903480
Blocks: 903481
Attached patch patch revision 1Splinter Review
Attachment #788254 - Flags: review?(jgilbert)
Comment on attachment 788254 [details] [diff] [review]
patch revision 1

Review of attachment 788254 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContext.h
@@ +762,5 @@
> +    JS::Value GetParameter(JSContext* cx, WebGLenum pname, ErrorResult& rv);
> +    bool IsEnabled(WebGLenum cap);
> +
> +private:
> +    bool ValidateCapabilityEnum(WebGLenum cap, const char *info);

* to the left, since something else in this section does it.
Attachment #788254 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 788254 [details] [diff] [review]
> patch revision 1
> 
> Review of attachment 788254 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/canvas/src/WebGLContext.h
> @@ +762,5 @@
> > +    JS::Value GetParameter(JSContext* cx, WebGLenum pname, ErrorResult& rv);
> > +    bool IsEnabled(WebGLenum cap);
> > +
> > +private:
> > +    bool ValidateCapabilityEnum(WebGLenum cap, const char *info);
> 
> * to the left, since something else in this section does it.
Fixed.
Thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/e679d59f1437
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/e679d59f1437
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 908232
You need to log in before you can comment on or make changes to this bug.