Closed Bug 903476 Opened 8 years ago Closed 8 years ago

Update libspeex to opus-tools version, as it is the current upstream


(Core :: Audio/Video, defect)

Not set





(Reporter: padenot, Assigned: padenot)



(2 files)

jmspeex told me on IRC that the current upstream for the speex resampler is in opus-tools. This bug is about updating the script to reflect the difference in repo layout, update our patches, and to update the code to the last version.
This does the following:
- Change the script so it works with opus-tools instead of speex
- Update the code using the new
- Rebase the SSE detection patch on top of the new code
- Modify the Makefile because the way the symbols are exported has changed.
Attachment #788259 - Flags: review?(ehsan)
New resampling code, new fuzzing values.
Attachment #788260 - Flags: review?(ehsan)
Attachment #788259 - Flags: review?(ehsan) → review+
Comment on attachment 788260 [details] [diff] [review]
Update the fuzzing values in test_mediaDecoding.html because we changed the resampler. r=

Review of attachment 788260 [details] [diff] [review]:

::: content/media/webaudio/test/test_mediaDecoding.html
@@ +228,5 @@
>    var getExpected = new XMLHttpRequest();
>"GET", monoTest ? test.expectedMono : test.expected, true);
>    getExpected.responseType = "arraybuffer";
>    getExpected.onload = function() {
> +		dump("For " + test.url + " \n");

Please take this out!
Attachment #788260 - Flags: review?(ehsan) → review+
Pushed with the dump removed and a couple tweak to the fuzzing number so the test passes on 32bits OS. and a bit more fuzzing on win32 to fix an orange. and for android. Hopefully this is the last followup needed. For some reason, my try push [1] had lower numbers for win32, and success for android.

You need to log in before you can comment on or make changes to this bug.