903511 - Rename "GripClient" to "ObjectClient"

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Brandon Benvie [:benvie]]

All the Client/Actor pairs have the same prefix name which makes for a nice symmetry and makes lot of sense. It's confusing to newcomers to the code to find the GripClient/ObjectActor incongruency.

Comment 1

[Anup Kumar [:reznord]]

Hi, 

My name is Anup. I have just started contributing to open source. I am a complete newbie to all these stuff. So if you assign me this bug I will try my level best to fix this and for me it will be a good startup also. So, please assign me this bug to me.

Thanks in Advance,

Regards,
A. Anup

Comment 2

[Edmund Wong (:ewong)]

Sorry. My mistake.  Missed Allamsetty's request.  Re-assigning to allamsetty.

Comment 3

[velocirabbit]

Attachment: debugger-view.js

GripClient replaced in this js file already.

Comment 4

[velocirabbit]

Attachment: scratchpad.js

GripClient replaced in this js file already.

Comment 5

[velocirabbit]

Attachment: webconsole.js

GripClient replaced in this js file already.

Comment 6

[velocirabbit]

Attachment: test_object_actor.html

Comment 7

[velocirabbit]

Attachment: test_bug819670_getter_throws.html

Comment 8

[velocirabbit]

Attachment: test_object_actor_native_getters.html

Comment 9

[velocirabbit]

Attachment: test_object_actor_native_getters_lenient_this.html

Comment 10

[velocirabbit]

http://mxr.mozilla.org/comm-central/search?string=GripClient

Comment 11

[Anup Kumar [:reznord]]

Attachment: This contains the changes made to the code as per the bug.

Comment 12

[Anup Kumar [:reznord]]

nfitzgerald:

Hi, 

I have got assigned to this bug. After working on this bug I have submitted a patch file which consists of the changes which I have made to the code. I request you to go through the patch file.

Thanks in advance.

Regards,
A.Anup.

Comment 13

[Anup Kumar [:reznord]]

Attachment: This is the modified one comparing to the first one.

Comment 14

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 788988 [details] [diff] [review]
This contains the changes made to the code as per the bug.

Review of attachment 788988 [details] [diff] [review]:
-----------------------------------------------------------------

Anup, thank you for the patch! This looks good to me, so now I am going to push it to try server[0] to run the tests on all of our platforms. Assuming that the tests come back ok, I will push it to fx-team, where it will incubate for a day or so before going into mozilla-central, and then showing up in the next Nightly builds!

[0] https://wiki.mozilla.org/ReleaseEngineering/TryServer

Comment 15

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Here is the try push: https://tbpl.mozilla.org/?tree=Try&rev=213721509e84

Results will start to be available within an hour or so, and complete in a few hours.

Comment 16

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Anup, also in the future please only attach the patch, and not the whole files. We only care about what has changed :) Thanks!

Comment 17

[Anup Kumar [:reznord]]

I am not the one who has upoaded the files sir. Anyway thanks for the advice.

Comment 18

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 789000 [details] [diff] [review]
This is the modified one comparing to the first one.

Review of attachment 789000 [details] [diff] [review]:
-----------------------------------------------------------------

Woops, I had r+'d the wrong patch.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ab760067683b

Thanks for the patch, Anup! One request, please make sure that you configure Mercurial to generate patches with the necessary checkin metadata. It makes life much easier for those landing on your behalf. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 20

[Anup Kumar [:reznord]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #19)
> https://hg.mozilla.org/integration/fx-team/rev/ab760067683b
> 
> Thanks for the patch, Anup! One request, please make sure that you configure
> Mercurial to generate patches with the necessary checkin metadata. It makes
> life much easier for those landing on your behalf. Thanks!
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

what do u mean by [fixed-in-fx-team]?

Comment 21

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We add [fixed-in-fx-team] when a patch lands in the fx-team repo. Once fx-team is merged into mozilla-central, the bug will be RESOLVED FIXED. It just helps us keep track of things.

Comment 22

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ab760067683b

Comment 23

[Ryan VanderMeulen [:RyanVM]]

This is already checked in, per comments 19 and 22.