Closed Bug 903531 Opened 8 years ago Closed 8 years ago
Update android-sync (git repo) fennec copy code script to export JUnit 3 test suite to mozilla-central
This is the first step towards building the JUnit 3 test suite as part of the mozilla-central build. This will mean updating the copy code script to copy the relevant test and test harness files; negotiating whatever changes are needed to harmonize m-c and android-sync; and landing the first version of the test suite onto m-c.
The android-sync test suite covers all the Android Background Services, including Sync, Product Announcments, and Firefox Health Report. It is developed at https://github.com/mozilla-services/android-sync This is the patch that results from applying the github pull request. I settled on `instrumentation-tests` for this series but we can land this somewhere else easily.
Comment on attachment 795740 [details] [diff] [review] First copy of android-sync JUnit 3 test suite. r=rnewman Looks OK to me. You could do something like mobile/android/base/tests/junit/src/..
Attachment #795740 - Flags: feedback?(mark.finkle) → feedback+
Comment on attachment 795740 [details] [diff] [review] First copy of android-sync JUnit 3 test suite. r=rnewman Review of attachment 795740 [details] [diff] [review]: ----------------------------------------------------------------- a-s code looks good. Couple of notes on the file list. ::: mobile/android/base/android-services-files.mk @@ +822,5 @@ > + src/org/mozilla/android/sync/test/AndroidBrowserHistoryRepositoryTest.java \ > + src/org/mozilla/android/sync/test/AndroidBrowserRepositoryTest.java \ > + src/org/mozilla/android/sync/test/AndroidSyncTestCase.java \ > + src/org/mozilla/android/sync/test/BookmarksTest.java \ > + src/org/mozilla/android/sync/test/EmptyTest.java \ Can we get rid of this? @@ +868,5 @@ > + src/org/mozilla/android/sync/test/helpers/simple/SimpleSuccessFinishDelegate.java \ > + src/org/mozilla/android/sync/test/helpers/simple/SimpleSuccessStoreDelegate.java \ > + src/org/mozilla/android/sync/test/helpers/WaitHelper.java \ > + src/org/mozilla/android/sync/test/helpers/WBORepository.java \ > + src/org/mozilla/android/sync/test/MyActivityTest.java \ ? Did you purge your source tree before running the copy script?
Attachment #795740 - Flags: review?(rnewman) → review+
Enough changed that you should take another look at this.
Comment on attachment 808724 [details] [diff] [review] 903531.patch What I've read of this, and the GitHub equivalent, looks good to me. Let's get a try build to make sure we aren't accidentally breaking something else in landing this stuff.
Attachment #808724 - Flags: review?(rnewman) → review+
(In reply to Richard Newman [:rnewman] from comment #5) > Comment on attachment 808724 [details] [diff] [review] > 903531.patch > > What I've read of this, and the GitHub equivalent, looks good to me. > > Let's get a try build to make sure we aren't accidentally breaking something > else in landing this stuff. I've done several try builds with this (and follow-ups for building) landed. For example, https://tbpl.mozilla.org/?tree=Try&rev=0014a4798289. This is straight addition, so I'm not worried.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.