Closed
Bug 903532
Opened 11 years ago
Closed 9 years ago
[Fig] Follow-up: Reposition empty hint for better tablet layout
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: liuche, Unassigned, Mentored)
References
Details
(Whiteboard: [lang=java])
Mocks here: Landscape http://cl.ly/image/0G1a1J1E1W0X Portrait http://cl.ly/image/282f172I0O3y
Reporter | ||
Updated•11 years ago
|
Summary: [Fig] Follow-up: Reposition empty hint for better → [Fig] Follow-up: Reposition empty hint for better tablet layout
Reporter | ||
Updated•11 years ago
|
Priority: -- → P2
Reporter | ||
Comment 1•11 years ago
|
||
The fix for this bug involves creating tablet-specific xml files (that match the mocks) in mobile/android/base/resources/layout-large-land and layout-large-port.
Whiteboard: [mentor=liuche][lang=java]
this would be a perfect first bug for me. you ok with me taking it?
Reporter | ||
Comment 3•11 years ago
|
||
Absolutely! In case you're just starting out, be sure to check out our main wiki (https://wiki.mozilla.org/Mobile/Fennec/Android) for instructions on building, coding style, testing, etc. The tricky things about this bug will be getting the layouts visually correct in all cases (position that works correctly with rotation, different tablet sizes) which can sometimes be frustrating with Android. However, there are certainly existing layouts to use as a reference. The Java files for these pages can be found in mobile/android/base/home, and you can look for mEmptyView to see how the resources are hooked in. The resources themselves are located in mobile/android/base/resources/layout. Let me know if you have questions on building or getting started. Do you have a tablet to test on? And as always, feel free to drop into #mobile and ask questions!
I don't have a tablet but I might be able to get my hands on one for this. until I do or at least have my build environment setup don't assign this to me. In the meantime while I try borrow a tablet, Ill try another bug. If this is still available then I'll definately take it. Thanks for the advice on getting sttarted, it should keep me busy this weekend
Assignee | ||
Updated•10 years ago
|
Mentor: liuche
Whiteboard: [mentor=liuche][lang=java] → [lang=java]
Reporter | ||
Comment 5•9 years ago
|
||
Closing this bug because this design applied to a previous version of about:home - now the header tabs each have their own empty icon. The next iteration of this is probably bug 1091826.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•