903564 - Opening the findbar shifts the page content downwards on pages without scroll-bars

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

Bug 893446 did not fix

Steps To Reproduce:
1. Open http://www.din.or.jp/~hagi3/JavaScript/JSTips/DHTML/PropertyViewer/PropViewer.htm
2. Open Findbar

Actual Results:
Page move downward

Expected Results:
Should not

Comment 1

[Markus Stange [:mstange]]

Yes :(

I don't know what to do here, except redesigning the findbar completely to work like in Chrome.

Comment 2

[David Regev]

I commented on this issue in bug 893446 comment 92:
> In the case of short pages, we could fix the min-height of the page to the
> height of the viewport. That way, the extra whitespace would be part of the
> page, and all of that could be scrolled up as the find bar comes down. In
> other words, if the page is too short make it taller. This is, admittedly,
> kind of a hack, though it might be preferable to having any cases where the
> page shifts. As a side note, let me point out that, with short pages, you’re
> somewhat less likely to run a find, since you can see the entire page all at
> once.

I checked this on Nightly, and modifying the min-height and overflow properties for the page when the find bar appears actually seems to work. I added this to the page:

    html { min-height: calc(100% + 38px); overflow: hidden; }

(38px is the height of the find bar on Ubuntu.) I tried this on google.com, and found no user-visible issues or weirdness. This worked on the page in comment 0 as well.

The way I did it is indeed quite hacky, but the basic idea seems promising, so perhaps a real solution can be implemented.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Also fixed by bug 914180, right?

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #3)
> Also fixed by bug 914180, right?

Yes, it was. Thanks for tracking this! I'm closing this as FIXED, but please change the flag if another resolution seems more appropriate.