903732 - Likely leak in nsSVGTextFrame2::SetupInheritablePaint()...

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Johnny Stenback (:jst)]

Attachment: DMD log snippet.

After having run my browser for quite some time I see ~450 megs of memory in heap-unclassified, ~200 of which seems to be coming from inside nsSVGTextFrame2::SetupInheritablePaint(). I don't understand that code well enough to say much about it off the top of my head, but closing the one webpage that I know uses SVG and updates all the time (real time bandwidth usage graph from a router running tomato) does *not* make this memory be released.

Happy to try to help dig in here if the stacks in the attached DMD data isn't enough to know what's going on here. This is Firefox running in a vnc session, so no accelerated anything here.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

If you apply this patch, does that fix the leak?

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 788497 [details] [diff] [review]
patch

It does indeed! Thanks for the fix!

Comment 3

[Johnny Stenback (:jst)]

Also, this reminds me of bug 836173 which was the identical problem in a different spot. I did a quick grep for other occurrences of this same pattern but didn't find any... Others might want to dig in a bit too though, as I only glanced at this myself.

Comment 4

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d54129b46ca9

Comment 5

[Cameron McCormack (:heycam)]

Thanks for fixing my error, Robert. :)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d54129b46ca9