903778 - Move dom::Date into its own files

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

No point in dumping this on everyone who includes BindingDeclarations.h

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

What's the goal here?  It doesn't appear to let us remove any includes from BindingDeclarations.h.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I think reducing the size of BindingDeclarations.h is useful, even if we can't drop includes, as it's included in some 2600 non-.h files (and increasing).

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 788549 [details] [diff] [review]
Patch v1

Review of attachment 788549 [details] [diff] [review]:
-----------------------------------------------------------------

Ok then.

I wonder if it's worth inlining some more stuff now that not everything needs to include it.

::: content/html/content/src/HTMLInputElement.h
@@ +16,5 @@
>  #include "nsTextEditorState.h"
>  #include "nsCOMPtr.h"
>  #include "nsIConstraintValidation.h"
>  #include "nsDOMFile.h"
> +#include "mozilla/dom/Date.h"

I think this just needs a forward declaration of Date to use in Nullable<>

::: dom/bindings/BindingDeclarations.h
@@ -712,5 @@
> -
> -private:
> -  double mMsecSinceEpoch;
> -};
> -

So we should probably leave a forward decl here.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f02c696df785