Move dom::Date into its own files

RESOLVED FIXED in mozilla26

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla26
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 788549 [details] [diff] [review]
Patch v1

No point in dumping this on everyone who includes BindingDeclarations.h
Attachment #788549 - Flags: review?(khuey)
What's the goal here?  It doesn't appear to let us remove any includes from BindingDeclarations.h.
Flags: needinfo?(Ms2ger)
(Assignee)

Comment 2

5 years ago
I think reducing the size of BindingDeclarations.h is useful, even if we can't drop includes, as it's included in some 2600 non-.h files (and increasing).
Flags: needinfo?(Ms2ger)
Comment on attachment 788549 [details] [diff] [review]
Patch v1

Review of attachment 788549 [details] [diff] [review]:
-----------------------------------------------------------------

Ok then.

I wonder if it's worth inlining some more stuff now that not everything needs to include it.

::: content/html/content/src/HTMLInputElement.h
@@ +16,5 @@
>  #include "nsTextEditorState.h"
>  #include "nsCOMPtr.h"
>  #include "nsIConstraintValidation.h"
>  #include "nsDOMFile.h"
> +#include "mozilla/dom/Date.h"

I think this just needs a forward declaration of Date to use in Nullable<>

::: dom/bindings/BindingDeclarations.h
@@ -712,5 @@
> -
> -private:
> -  double mMsecSinceEpoch;
> -};
> -

So we should probably leave a forward decl here.
Attachment #788549 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f02c696df785
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.