Closed Bug 903791 Opened 7 years ago Closed 7 years ago

Make HTMLOptionElement.index infallible

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
In the simple case, GetOptionIndex can't fail.
Attachment #788562 - Flags: review?(mounir)
Comment on attachment 788562 [details] [diff] [review]
Patch v1

Review of attachment 788562 [details] [diff] [review]:
-----------------------------------------------------------------

In ::Index(), could you define a variable that will be the default returned value. I would like this to be clear that 0 is the value to return when the index is not present. If there is a static const variable, it might make things clearer.
Attachment #788562 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/698c66920a41
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Depends on: 1250401
You need to log in before you can comment on or make changes to this bug.