903819 - Don't include Layers.h everywhere, part 4

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Log

Seriously?

Comment 2

[David Zbarsky (:dzbarsky)]

Attachment: Don't include Layers.h everywhere, part 4 r=nrc

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

Comment 4

[Nick Cameron [:nrc]]

Comment on attachment 788631 [details] [diff] [review]
Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

Review of attachment 788631 [details] [diff] [review]:
-----------------------------------------------------------------

You should get a layout peer to review this. Looks good to me, but better to get review from someone who knows this stuff.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 788631 [details] [diff] [review]
Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

Review of attachment 788631 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsDisplayList.cpp
@@ +3030,5 @@
> +
> +/* static */ void
> +nsPresContext::NotifySubDocInvalidation(ContainerLayer* aContainer,
> +                                        const nsIntRegion& aRegion)
> +{

Moving nsPresContext code to nsDisplayList.cpp is very undesirable IMHO.

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 788631 [details] [diff] [review]
Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

This was fixed in bug 904541.

Comment 7

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/501af2a0ca17

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/501af2a0ca17

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Ed Morley [:edmorley UTC+1] from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/501af2a0ca17

Why did HTMLAnchorElement.h gain an nsContentUtils.h include?

Comment 10

[David Zbarsky (:dzbarsky)]

(In reply to :Ms2ger from comment #9)
> (In reply to Ed Morley [:edmorley UTC+1] from comment #8)
> > https://hg.mozilla.org/mozilla-central/rev/501af2a0ca17
> 
> Why did HTMLAnchorElement.h gain an nsContentUtils.h include?

I'm not sure.  I saw build errors at some point about nsContentUtils being undefined, but I think it was for another patch.  I'll remove it when inbound opens.

Comment 11

[David Zbarsky (:dzbarsky)]

Removed the include: https://hg.mozilla.org/integration/mozilla-inbound/rev/89bec7278d27

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/89bec7278d27