Closed Bug 903819 Opened 6 years ago Closed 6 years ago

Don't include Layers.h everywhere, part 4

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Attached file Log
Seriously?
Assignee: nobody → dzbarsky
Attachment #788631 - Flags: review?(ncameron)
Comment on attachment 788631 [details] [diff] [review]
Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

Review of attachment 788631 [details] [diff] [review]:
-----------------------------------------------------------------

You should get a layout peer to review this. Looks good to me, but better to get review from someone who knows this stuff.
Attachment #788631 - Flags: review?(ncameron)
Attachment #788628 - Flags: review?(ncameron) → review+
Attachment #788631 - Flags: review?(roc)
Comment on attachment 788631 [details] [diff] [review]
Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

Review of attachment 788631 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsDisplayList.cpp
@@ +3030,5 @@
> +
> +/* static */ void
> +nsPresContext::NotifySubDocInvalidation(ContainerLayer* aContainer,
> +                                        const nsIntRegion& aRegion)
> +{

Moving nsPresContext code to nsDisplayList.cpp is very undesirable IMHO.
Comment on attachment 788631 [details] [diff] [review]
Part 2 - Don't include Layers.h in nsPresContext.h r=nrc

This was fixed in bug 904541.
Attachment #788631 - Attachment is obsolete: true
Attachment #788631 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/501af2a0ca17
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
(In reply to Ed Morley [:edmorley UTC+1] from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/501af2a0ca17

Why did HTMLAnchorElement.h gain an nsContentUtils.h include?
Flags: needinfo?(dzbarsky)
(In reply to :Ms2ger from comment #9)
> (In reply to Ed Morley [:edmorley UTC+1] from comment #8)
> > https://hg.mozilla.org/mozilla-central/rev/501af2a0ca17
> 
> Why did HTMLAnchorElement.h gain an nsContentUtils.h include?

I'm not sure.  I saw build errors at some point about nsContentUtils being undefined, but I think it was for another patch.  I'll remove it when inbound opens.
Flags: needinfo?(dzbarsky)
You need to log in before you can comment on or make changes to this bug.