903877 - pdf viewer selected text highlight too tall, overlaps with next line

Status: RESOLVED WORKSFORME

(Firefox :: PDF Viewer, defect)

Description

[Doug Hockin]

Attachment: Screen Shot showing overlapped text selection highlights

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130730113002

Steps to reproduce:

Selected an area of text that included multiple lines

Mac OS X 10.7.5 with FF 23


Actual results:

The highlight is taller than an individual line, so that the highlight from each line overlaps that of the next line. Since the highlight is transparent, the overlapped region is darker colored.


Expected results:

There should be no overlap in the highlight between lines.

Comment 1

[Doug Hockin]

Document URL: http://nescc.sourceforge.net/papers/nesc-pldi-2003.pdf

Comment 2

[Brendan Dahl [:bdahl]]

I'm unable to reproduce. Can you try with the nightly version of Firefox?

Comment 3

[Doug Hockin]

Reproduces for me with the nightly. See new attachment. 26.0a1 (2013-09-10)

Comment 4

[Doug Hockin]

Attachment: Screen Shot while running current nightly build

Comment 5

[Doug Hockin]

Also, but perhaps a separate problem, the highlights do not continue through the whole file, only the first few pages. If you scroll down through the file (I'm viewing it in Fit to width mode) only the first couple pages are highlighted. To get the unhighlighted subsequent page to highlight you have to click Highlight All again (off?) and then again (on?). But that only highlights a few more pages and when you get to additional pages that aren't highlighted you have to do the click off / click on thing again to get more highlighted.

Comment 6

[Doug Hockin]

Here's another URL to use for testing:

http://www.nps.gov/ncrc/programs/rtca/helpfultools/launchguide/8.pdf

Comment 7

[bugcon]

FF29 got a new pdf.js version, can you try with latest release and see if you still get this?

Comment 8

[Doug Hockin]

Problem is still there just as thick as ever. Try searching for the letter 'a' with "Highlight All" enabled. Compare it to Preview.

http://www.nps.gov/ncrc/programs/rtca/helpfultools/launchguide/8.pdf

Comment 9

[Doug Hockin]

The highlight no longer too tall, it's just badly misplaced on the page, not over the text it's supposed to be over.

Comment 10

[bugcon]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

(In reply to Doug Hockin from comment #9)
> The highlight no longer too tall, it's just badly misplaced on the page, not
> over the text it's supposed to be over.

Ok, this is a different issue then, but i _can_ reproduce it here.

Comment 11

[bugcon]

Attachment: Screenshot showing misplaced highlights using pdf.js in FF29

Comment 12

[bugcon]

Attachment: 2nd Screenshot showing misplaced highlights using pdf.js in FF29

This screenshot shows the problem a bit more clearly, including seeming to highlight some letters that don't match the search term - see 4th last word 'freezing' with highlight for letter 'a'.

Comment 13

[bugcon]

Attachment: Screenshot using pdf.js dev add-on showing correct highlighting

I just tested this again using the dev version add-on of pdf.js and it seems to be highlighting correctly with it.

Doug, can you try it with the add-on and see if it works?

https://github.com/mozilla/pdf.js#firefox
http://mozilla.github.io/pdf.js/extensions/firefox/pdf.js.xpi

Comment 14

[Doug Hockin]

I've installed it in FF 29. But how to I tell whether it's using this new one rather than the one FF 29 had built in? Is there somewhere I can look to see which is running -- I poked around and didn't see a version number accessible anywhere. Does the "add-on" one override the builtin one?

Comment 15

[bugcon]

You can see the pdf.js version being used by opening a PDF and looking in the Web Console (Command-Option-K on OSX i think): https://developer.mozilla.org/en-US/docs/Tools/Web_Console

The add-on should automatically override the built in pdf.js

Comment 16

[Doug Hockin]

Attachment: Bad highlights and web console showing pdf.js version.

Added an image showing bad highlights and also has the web console visible to show pdf.js version.

Does what I see there mean this is actually Adobe code?

Comment 17

[Kenan]

Does this bug still exist?

I cannot reproduce with Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Firefox/97.0 or older versions by mozregression.

Comment 18

[Marco Castelluccio [:marco]]

Please reopen if you can still reproduce.

Comment 19

[Doug Hockin]

Even though this was closed (and I just retested and confirm it's fixed) there was a request for needed info that I didn't respond to and it still shows up in my "Requests for your:" at the top of the page. This seems like a bug in Bugzilla itself? Not sure how to report those.

I found the needs info checkbox at the bottom and cleared it. But it still seems like a bug in Bugzilla that that doesn't get automatically cleared when the bug gets closed.

Comment 20

[Marco Castelluccio [:marco]]

There are many cases in which we still need information from people after bugs are closed (e.g. to ask them to confirm the fix), that's why it isn't automatically cleared.