903947 - [Messages] The last recipient is copied everytime when selecting recipeint for removing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Leo]

1. Title: The last recipient is copied everytime when selecting recipeint for removing 
2. Precondition: Add some contacts in the contact application
3. Tester's Action:  Message -> New Message -> Add 2~3 contacts in To field -> Enter some text -> Select recipient in to field -> Click cancel in remove recipient contact
4. Detailed Symptom (ENG.) : The last contact is added again when selecting cancel button in remove recipient pop-up
5. Expected:  The contact should not added when selecting cancel button 
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision:   c5e8358d753b8954de7b1a8c3e00944617aeec5e
9. Personal email id: [e-mail]

Comment 1

[Leo]

Hi,

This issue will happen after adding the text in message field -> Go back to recipeint field and try removing the existing contact.

Comment 2

[Leo]

Hello Waldron,

Can you please check this issue and provide a fix.
There is one more Bug:903943.I think that both are related.
Please take a look of both the issues.

Reproducible steps:
Drag the 'to field' if you drag it down once, then make it move it up, and then drag it down a second time, then it's 100%

Thanks,
Leo

Comment 3

[Rick Waldron [:rwaldron]]

Attachment: Github Pull Request https://github.com/mozilla-b2g/gaia/pull/11488

- Clicks on accepted recipients...
    - while manually entering a recipient:
        - Two rendered recipients
        - A placeholder for the cursor
    -  with only accepted recipients:
        - no changes, no assimilated recipients
    - with no placeholder at end of list:
        - no changes, no assimilated recipients

This patch also fixes https://bugzilla.mozilla.org/show_bug.cgi?id=903943

Comment 4

[Leo]

Hi,

I have tested the patch available.
I am not able to reproduce the above mentioned scenario.
But there are some scenarios where the keyboard is not disappering

1.Add 2~3 contacts-> Enter text in message field->Drag down the 'to field'->Send the message
Actual: Once the send button is pressed,the Keyboard is still shown in the thread_list
Expected: The keyboard should disapper once the send button is pressed.

2.Add 2~3 contacts -> Enter one number manually -> select the entered number -> The number comes in to edit mode -> then select the added contact(recipient) 
Actual:After selecting the recipient,the keyboard is still shown in the recipient(remove,cancel) pop-up.
Expected: The keyboard should disapper when the recipient is selected.

Thanks,

Comment 5

[Julien Wajsberg [:julienw]]

About 2. I think we can fix it here. Let's jus focus the dialog that is shown (set tabIndex = -1 on the dialog container + call focus on it).
About 1. we should blur from the recipient panel when we exit the #new mode. I think we could fix it here too but should this really block leo ?

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 789050 [details] [review]
Github Pull Request https://github.com/mozilla-b2g/gaia/pull/11488

Added comments on github in addition to comment 5.

I question the fact that we add a workaround in recipients.js while I think the fix should be in dialog.js (or maybe in both to prevent other bugs).

Comment 7

[Rick Waldron [:rwaldron]]

Filed bug 904640 for 

(In reply to Leo from comment #4)
> 1.Add 2~3 contacts-> Enter text in message field->Drag down the 'to
> field'->Send the message
> Actual: Once the send button is pressed,the Keyboard is still shown in the
> thread_list
> Expected: The keyboard should disapper once the send button is pressed.

Comment 8

[Rick Waldron [:rwaldron]]

Updated fix outline:

- Clicks on accepted recipients...
    - Should close the keyboard, if it's a known contact recipient
    - while manually entering a recipient:
        - Two rendered recipients
        - A placeholder for the cursor
    -  with only accepted recipients:
        - no changes, no assimilated recipients
    - with no placeholder at end of list:
        - no changes, no assimilated recipients

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 789050 [details] [review]
Github Pull Request https://github.com/mozilla-b2g/gaia/pull/11488

r=me with nits

please check that the unit tests are passing before merging !
thanks !

Comment 10

[Rick Waldron [:rwaldron]]

gaia@master https://github.com/mozilla-b2g/gaia/commit/d198618aa9452f434b476f12f7a32d0ac85768a5

gaia@v1-train https://github.com/mozilla-b2g/gaia/commit/913bcdc9d859516133fca5560607e585011dd461

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ad02f2832d0

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 913bcdc9d859516133fca5560607e585011dd461